fixed icd 'closing brace expected' issue#1960
Open
shodiBoy1 wants to merge 2 commits into
Open
Conversation
Collaborator
Coverage Report for CI Build 26283358163Coverage increased (+0.004%) to 71.119%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats💛 - Coveralls |
hohwille
approved these changes
May 21, 2026
Member
hohwille
left a comment
There was a problem hiding this comment.
@shodiBoy1 thanks for your PR. Fix looks sane to me. Seems that old bash on x86 mac does not support the short :: form so you make it more explicit and therefore old bash version compatible. 👍
You can add the CHANGELOG entry and take the PR ready for review so I can merge.
Contributor
Author
|
@hohwille all done , can be merged! |
Member
|
@shodiBoy1 we have some CLA issues. Seems you mixed commits from different emails/accounts. |
7cd5a81 to
f000bd0
Compare
Contributor
Author
|
@hohwille cla is fixed, i tested and pushed directly from my mac intel thats why i guess cla didnt pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1185
Implemented changes:
${1::1}shortcut with the POSIX-extended${1:0:1}form incli/src/main/package/functions(L34 and L59). Same first-character extraction, but parses in every zsh version (5.8.1 errored with "closing brace expected"; 5.9+ accepts both).Testing instructions
functionsfile into your installation).-
icd -h-> prints usage (was:icd:1: closing brace expected)-
icd -p <project> -w <workspace>-> cd's into the workspace (was:icd:26: closing brace expected)Checklist for this PR
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal