#1392: Smart completions#1859
Open
HenokLachmann wants to merge 50 commits into
Open
Conversation
HenokLachmann
added
completion
HenokLachmann
force-pushed
the
feature/#1392-smart-completions
branch
from
499ecbe to
d4ae88b
Compare
Collaborator
Coverage Report for CI Build 26101908636Coverage increased (+0.003%) to 70.982%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions240 previously-covered lines in 23 files lost coverage.
Coverage Stats
💛 - Coveralls |
tineff96
reviewed
May 20, 2026
Contributor
tineff96
left a comment
tineff96
left a comment
There was a problem hiding this comment.
Reviewed and tested.
- mvn clean test passed
- verified mvn CLI behavior and completion
The changes look solid and work as expected.
I’m still relatively new to the project, but everything seems correct from my side.
Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1392
Implemented changes:
Auto-completion is extended for the
Mvncommandlet. It enables autocompletion for theShellCommandletas well as for bash. Completion is supported for the last word as well as intermittent words on a commandline. Completion covers the following:clean,install,package--fail-fast-Dexec.mainClass=<classname>Whitespace is excluded after a completed trailing
=by differentiating partial from full completions. Merged short options are also supported as they are for present options.Completion is based on
Propertyinstances, but properties are also used as stand-in replacements. Examples are therepositoryproperty forRepositoryCommandletor thecommandletproperty forHelpCommandlet. These are not literal, they should not participate in autocompletion. A new boolean propertyplaceholderis introduced to exclude them from completion.A bug existed in the current implementation that would complete the
exitsubcommand infinitely. This is fixed by this PR by makingexitan ordinaryKeywordPropertyand dynamically adding it when a shell session is started.Checklist for this PR
Make sure everything is checked before merging this PR. For further info please also see
our DoD.
mvn clean testlocally all tests pass and build is successful#«issue-id»: «brief summary»(e.g.#921: fixed setup.bat). If no issue ID exists, title only.In Progressand assigned to you or there is no issue (might happen for very small PRs)with
internal