Skip to content

#1687: remove JLine Warning by enabling native access#1769

Merged
hohwille merged 16 commits intodevonfw:mainfrom
MarvMa:feature/#1687-fix-JLine-warning
Mar 27, 2026
Merged

#1687: remove JLine Warning by enabling native access#1769
hohwille merged 16 commits intodevonfw:mainfrom
MarvMa:feature/#1687-fix-JLine-warning

Conversation

@MarvMa
Copy link
Contributor

@MarvMa MarvMa commented Mar 24, 2026

This PR fixes #1687

Implemented changes:

  • removed JLine warning by adding --enable-native-access=ALL-UNNAMED to the build args of graalVM

Checklist for this PR

Make sure everything is checked before merging this PR. For further info please also see
our DoD.

  • When running mvn clean test locally all tests pass and build is successful
  • PR title is of the form #«issue-id»: «brief summary» (e.g. #921: fixed setup.bat). If no issue ID exists, title only.
  • PR top-level comment summarizes what has been done and contains link to addressed issue(s)
  • PR and issue(s) have suitable labels
  • Issue is set to In Progress and assigned to you or there is no issue (might happen for very small PRs)
  • You followed all coding conventions
  • You have added the issue implemented by your PR in CHANGELOG.adoc unless issue is labeled
    with internal

@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Mar 24, 2026
@MarvMa MarvMa self-assigned this Mar 24, 2026
@MarvMa MarvMa added the enhancement New feature or request label Mar 24, 2026
@coveralls
Copy link
Collaborator

coveralls commented Mar 24, 2026

Pull Request Test Coverage Report for Build 23639391261

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.005%) to 70.432%

Files with Coverage Reduction New Missed Lines %
com/devonfw/tools/ide/tool/ide/IdeToolCommandlet.java 1 78.33%
Totals Coverage Status
Change from base Build 23639040345: -0.005%
Covered Lines: 10784
Relevant Lines: 14705

💛 - Coveralls

@MarvMa MarvMa changed the title Feature/#1687 fix j line warning #1687: remove JLine Warning by enabling native access Mar 24, 2026
@MarvMa MarvMa marked this pull request as ready for review March 24, 2026 12:21
@MarvMa MarvMa moved this from 🆕 New to Team Review in IDEasy board Mar 24, 2026
@jakozian jakozian self-requested a review March 24, 2026 12:42
@jakozian jakozian self-assigned this Mar 24, 2026
@jakozian jakozian removed their request for review March 24, 2026 12:43
Copy link
Contributor

@jakozian jakozian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

The changes successfully removed the jline warnings, whenever a progress bar is visible.

@MarvMa MarvMa moved this from Team Review to 👀 In review in IDEasy board Mar 25, 2026
@MarvMa MarvMa removed this from IDEasy board Mar 25, 2026
@MarvMa MarvMa requested a review from hohwille March 25, 2026 12:45
@github-project-automation github-project-automation bot moved this to 🆕 New in IDEasy board Mar 26, 2026
Copy link
Member

@hohwille hohwille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarvMa thanks for your PR. Nice solution 👍
I added a random review comment to mark the the CHANGELOG needs to be extended so we do not forget before merge.
Once added, this is ready for merge.

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in IDEasy board Mar 26, 2026
@MarvMa MarvMa moved this from 👀 In review to 🆕 New in IDEasy board Mar 26, 2026
@MarvMa MarvMa removed this from IDEasy board Mar 26, 2026
@MarvMa
Copy link
Contributor Author

MarvMa commented Mar 26, 2026

@hohwille The changelog is updated 👍

@hohwille hohwille merged commit b21731a into devonfw:main Mar 27, 2026
2 checks passed
laert-ll pushed a commit to laert-ll/IDEasy that referenced this pull request Mar 27, 2026
…#1769)

Co-authored-by: Jörg Hohwiller <hohwille@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JLine causes warning about restricted method

4 participants