Skip to content

Close FileOutputStream in downloadFileWithProgress #1762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tejasae-afk wants to merge 1 commit into from
Closed

Close FileOutputStream in downloadFileWithProgress #1762

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 15 additions & 14 deletions cli/src/main/java/com/devonfw/tools/ide/io/FileAccessImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,21 +172,22 @@ private void downloadFileWithProgressBar(String url, Path target, HttpResponse<I
int count;

try (InputStream body = response.body();
FileOutputStream fileOutput = new FileOutputStream(target.toFile());
BufferedOutputStream bufferedOut = new BufferedOutputStream(fileOutput, data.length);
IdeProgressBar pb = this.context.newProgressBarForDownload(contentLength)) {
while (!fileComplete) {
count = body.read(data);
if (count <= 0) {
fileComplete = true;
} else {
bufferedOut.write(data, 0, count);
pb.stepBy(count);
try (FileOutputStream fileOutput = new FileOutputStream(target.toFile())) {
BufferedOutputStream bufferedOut = new BufferedOutputStream(fileOutput, data.length);
IdeProgressBar pb = this.context.newProgressBarForDownload(contentLength)) {
while (!fileComplete) {
count = body.read(data);
if (count <= 0) {
fileComplete = true;
} else {
bufferedOut.write(data, 0, count);
pb.stepBy(count);
}
}
} catch (Exception e) {
throw new RuntimeException(e);
}
}
}
} catch (Exception e) {
throw new RuntimeException(e);
}
}

private void copyFileWithProgressBar(Path source, Path target) {
Expand Down
Loading