Skip to content

Conversation

@dev-ant
Copy link
Contributor

@dev-ant dev-ant commented Oct 22, 2025

📋 상세 설명

  • 클라이언트에서 경매작 검색 내역 검색 조건 뷰를 렌더링할 수 있도록, 검색 조건 조회 API 구현
  • flyway script로 검색 조건 데이터 테이블 auction_search_option_metadata 생성 및 초기 데이터 적재
  • 테스트 코드 작성

📊 체크리스트

  • PR 제목이 형식에 맞나요 e.g. feat: PR을 등록한다
  • 코드가 테스트 되었나요
  • 문서는 업데이트 되었나요
  • 불필요한 코드를 제거했나요
  • 이슈와 라벨이 등록되었나요

📆 마감일

Close #68

@dev-ant dev-ant requested a review from Copilot October 22, 2025 13:11
@dev-ant dev-ant self-assigned this Oct 22, 2025
@dev-ant dev-ant added the ✨feature 새로운 기능 추가 label Oct 22, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality for auction search option metadata by creating a new database table, API endpoint, and related business logic to provide clients with search filter information.

Key Changes

  • Database schema and initial data for storing search option metadata in auction_search_option_metadata table
  • API endpoint (/api/search-option) to retrieve active search options with metadata including field types and allowed values
  • Refactored AuctionHistorySearchRequest from class with Lombok annotations to record

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
V11__create_auction_search_option_metadata.sql Creates the auction_search_option_metadata table with JSON search condition storage
R__insert_auction_search_option_metadata.sql Inserts initial metadata for 16 search options (balance, critical, defense, etc.)
AuctionSearchOptionMetadata.java Entity class for search option metadata with JSON field support
AuctionSearchOptionRepositoryPort.java Repository interface defining methods to query search options
AuctionSearchOptionJpaRepository.java JPA repository with query methods for active options ordered by display order
AuctionSearchOptionRepositoryPortImpl.java Implementation of repository port using JPA repository
AuctionSearchOptionService.java Service layer handling JSON parsing and response transformation
SearchOptionMetadataResponse.java Response DTO containing search option details
FieldMetadata.java DTO representing individual field metadata (type, required, allowedValues)
AuctionSearchOptionController.java REST controller exposing GET endpoint for search options
AuctionSearchOptionServiceTest.java Comprehensive unit tests for the service layer
AuctionHistorySearchRequest.java Refactored from class to record with TODO for future price/date range searches
PriceSearchRequest.java New request record for price range filtering
AuctionHistoryQueryDslRepository.java Updated to use record accessor methods
AuctionHistoryServiceTest.java Updated test to use record constructor
gradle.properties Added Gradle auto-download configuration

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@github-actions
Copy link

github-actions bot commented Oct 22, 2025

✅ 테스트 결과 for PR

Build: success

🧪 테스트 실행 with Gradle
📈 Coverage: -0.00%

📁 테스트 결과
📁 커버리지 보고서 (HTML)

@codecov
Copy link

codecov bot commented Oct 22, 2025

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@dev-ant dev-ant merged commit 0299092 into dev Oct 22, 2025
1 check passed
@dev-ant dev-ant deleted the feat/impl-auction-option-search-meta-api branch October 22, 2025 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨feature 새로운 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

경매장 거래 내역 검색 조건 테이블 및 조회 API 구현

2 participants