-
Notifications
You must be signed in to change notification settings - Fork 1
feat: 경매장 거래 내역 검색 조건 테이블 및 조회 API 구현 #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements functionality for auction search option metadata by creating a new database table, API endpoint, and related business logic to provide clients with search filter information.
Key Changes
- Database schema and initial data for storing search option metadata in
auction_search_option_metadatatable - API endpoint (
/api/search-option) to retrieve active search options with metadata including field types and allowed values - Refactored
AuctionHistorySearchRequestfrom class with Lombok annotations to record
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| V11__create_auction_search_option_metadata.sql | Creates the auction_search_option_metadata table with JSON search condition storage |
| R__insert_auction_search_option_metadata.sql | Inserts initial metadata for 16 search options (balance, critical, defense, etc.) |
| AuctionSearchOptionMetadata.java | Entity class for search option metadata with JSON field support |
| AuctionSearchOptionRepositoryPort.java | Repository interface defining methods to query search options |
| AuctionSearchOptionJpaRepository.java | JPA repository with query methods for active options ordered by display order |
| AuctionSearchOptionRepositoryPortImpl.java | Implementation of repository port using JPA repository |
| AuctionSearchOptionService.java | Service layer handling JSON parsing and response transformation |
| SearchOptionMetadataResponse.java | Response DTO containing search option details |
| FieldMetadata.java | DTO representing individual field metadata (type, required, allowedValues) |
| AuctionSearchOptionController.java | REST controller exposing GET endpoint for search options |
| AuctionSearchOptionServiceTest.java | Comprehensive unit tests for the service layer |
| AuctionHistorySearchRequest.java | Refactored from class to record with TODO for future price/date range searches |
| PriceSearchRequest.java | New request record for price range filtering |
| AuctionHistoryQueryDslRepository.java | Updated to use record accessor methods |
| AuctionHistoryServiceTest.java | Updated test to use record constructor |
| gradle.properties | Added Gradle auto-download configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...til/the/eternity/auctionhistory/interfaces/rest/dto/request/AuctionHistorySearchRequest.java
Outdated
Show resolved
Hide resolved
✅ 테스트 결과 for PRBuild: success 🧪 테스트 실행 with Gradle |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
📋 상세 설명
auction_search_option_metadata생성 및 초기 데이터 적재📊 체크리스트
📆 마감일