infra: Github Actions Docker Compose CD 파이프 라인 구축 #41
Conversation
✅ 테스트 결과 for PRBuild: success 🧪 테스트 실행 with Gradle |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Pull Request Overview
This PR establishes a CD pipeline using GitHub Actions and Docker Compose for continuous deployment to cloud services. It includes infrastructure configuration changes to support production-like environments while optimizing API call frequency for development.
Key Changes:
- Added GitHub Actions workflow for automated Docker build and deployment
- Created Docker Compose configuration for containerized deployment
- Modified auction history API call frequency from hourly to every 4 hours
- Removed default values from JWT configuration properties
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/push-cd-dev.yml | GitHub Actions CD pipeline with Docker build, push, and remote deployment |
| docker-compose-dev.yaml | Docker Compose configuration for Spring application with health checks and logging |
| Dockerfile | Simple Docker image configuration using OpenJDK 21 |
| .dockerignore | Docker build context exclusions for security and optimization |
| src/main/resources/application-sample.yml | Updated cron schedule and removed JWT default values |
| auction-history: | ||
| delay-ms: 1000 | ||
| cron: "0 0 */1 * * *" # 1시간마다 실행 | ||
| cron: "0 0 */4 * * *" # 1시간마다 실행 |
There was a problem hiding this comment.
The comment says '1시간마다 실행' (runs every 1 hour) but the cron expression '0 0 */4 * * *' runs every 4 hours. The comment should be updated to '4시간마다 실행' to match the actual schedule.
| cron: "0 0 */4 * * *" # 1시간마다 실행 | |
| cron: "0 0 */4 * * *" # 4시간마다 실행 |
| - name: Deploy and Restart Container | ||
| run: | | ||
| ssh -i ~/.ssh/my-key.pem ${{ secrets.SERVER_USER }}@${{ secrets.SERVER_HOST }} << 'EOF' | ||
| mkdir -p /home/${{ secrets.SERVER_USER }}/app |
There was a problem hiding this comment.
The directory creation is duplicated - it's already done on line 51. This redundant command should be removed to avoid unnecessary operations.
| mkdir -p /home/${{ secrets.SERVER_USER }}/app |
| .gradle/ | ||
|
|
There was a problem hiding this comment.
The '.gradle/' directory is listed twice (lines 30 and 32). Remove the duplicate entry to clean up the file.
| .gradle/ |
🛠️ 인프라 변화
📝 상세 설명
매시간 0분 0초->4시간마다 0분 0초로 변경🧐 예상 결과
📊 체크리스트
📆 마감일