-
Notifications
You must be signed in to change notification settings - Fork 1
chore: 운영 서버 CD #139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 운영 서버 CD #139
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
혹시 이 폴더에 local용 docker-compose를 이 폴더에서 관리하려는 계획이셨나요?! |
bsko98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생많으셨습니다 LGTM 👍👍
간단한 질문 남겨뒀습니다!
|
|
||
| - name: Build (Gradle) & Docker build/tag | ||
| run: | | ||
| ./gradlew clean build -x test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
테스트를 제외하고 빌드한다 라는 내용으로 알고있는데, dev에 머지할 때 테스트 문제는 다 해결되니까 이렇게 하신거라고 생각하면 될까요??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵! dev 브랜치에는 이미 CI로 테스트가 확인된 상태로 올라가게됩니다.
또한 CD 프로세스 상에 필요한 것은 테스트가 아닌 jar 파일 빌드기 때문에 테스트를 진행하 않는 것이 빠른 프로세스 진행에 도움이 될 것이라고 생각했습니다!
#133 에서 추가했던 파일인데, 루트의 docker-local-compose.yaml과 중복된다고 생각하여 이번 PR에서 삭제조치했습니다! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR sets up continuous deployment for the production server by adding a new GitHub Actions workflow, updating deprecated Spring Boot properties in the application configuration, and removing an unused local-run docker-compose file.
Key Changes:
- Added production CD workflow that builds Docker images and deploys to production server via SSH
- Updated Redis configuration from deprecated
spring.redistospring.data.redisstructure - Removed unused
local-run/docker-compose.ymlfile
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
.github/workflows/deploy-with-docker-product.yml |
New production deployment workflow that builds/pushes Docker images and deploys to prod server using docker-compose |
src/main/resources/application.yml |
Updated Redis config to use spring.data.redis instead of deprecated spring.redis, removed duplicate spring.resources property, and modified prod profile Redis settings to use hardcoded values |
local-run/docker-compose.yml |
Removed entire file as it's no longer needed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
bsko98
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코파일럿 코드리뷰 반영에 상현이가 부탁했던 더미데이터 변경까지 너무 고생하셨습니다!
📋 상세 설명
📊 체크리스트
📆 마감일