Skip to content

HTML & CSS Projekt#184

Open
AlexKry96 wants to merge 7 commits intodevmentor-pl:masterfrom
AlexKry96:master
Open

HTML & CSS Projekt#184
AlexKry96 wants to merge 7 commits intodevmentor-pl:masterfrom
AlexKry96:master

Conversation

@AlexKry96
Copy link
Collaborator

No description provided.

Copy link
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Olek,

WOW! Projekt wygląda super! 🥇
Zostawiłem parę drobnych uwag!

Comment on lines +40 to +44
<a
href="#"
class="nav__link"
>
<li class="nav__link-item ">The Team</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Raczej zrobiłbym odwrotnie tj. najpierw li, potem a. Nie jest to błąd, nie ma to większego znaczenia, ale specyfikacja mówi, aby elementy liniowe (np. a) umieszczać w blokowych (np. li).

Comment on lines +206 to +207
<div class="team__members container">
<div class="team__member">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj też można zrobić ul > li, bo to "lista" członków zespołu (podobnie jak miałeś listę cen).

table {
border-collapse: collapse;
border-spacing: 0;
} No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants