Skip to content

Task: HTML and CSS basics#180

Open
satoshi300 wants to merge 12 commits intodevmentor-pl:masterfrom
satoshi300:master
Open

Task: HTML and CSS basics#180
satoshi300 wants to merge 12 commits intodevmentor-pl:masterfrom
satoshi300:master

Conversation

@satoshi300
Copy link
Collaborator

No description provided.

Copy link
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michale,

Świetnie sobie poradziłeś! - gratuluję! 👍 🥇
Zostawiłem parę drobnych uwag w komentarzach :)

<section class="header__image cell">

<figure class="header__image-style">
<img
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ten img niepotrzebnie "prześwituje" - wystarczy nadać "background" dla img na "biało" i będzie ok :)

index.html Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można zamiast div użyć section

index.html Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj również może być section

index.html Outdated
Comment on lines 73 to 74
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TUtaj bym zrobił ul > li bo mamy listę elementów, gdzie li to .feature__item

index.html Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj nawet zamiast div można dać article, bo każdy pakiet cenowy to jedna spójna treść.

Copy link
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Michale,

Super, o to chodziło! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments