Open
Conversation
devmentor-pl
approved these changes
Feb 10, 2025
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Kacprze,
Projekcik super! 👍
Zostawiłem drobne uwagi dot. znaczników.
Comment on lines
+24
to
+25
| <div class="header__actions text-right-sm-md-lg"> | ||
| <nav class="header__nav"> |
Owner
There was a problem hiding this comment.
Osobiście pominąłbym div - nie jest on niezbędny, a im mniej znaczników tym jest czytelniej.
Comment on lines
+26
to
+28
| <a class="header__nav-item" href="#team">The Team</a> | ||
| <a class="header__nav-item" href="#pricing">Pricing</a> | ||
| <a class="header__nav-item" href="#features">Features</a> |
Owner
There was a problem hiding this comment.
W przypadku nawigacji osobiście wolę trzymać się zasady ul > li
|
|
||
| <!-- Hero Content --> | ||
| <div class="hero__content text-center text-left-sm-md-lg two-column-flex-sm-md-lg"> | ||
| <div class="hero__text"> |
Owner
There was a problem hiding this comment.
Tutaj zaproponowałbym znacznik article, bo to jakaś spójna wypowiedź.
| </div> | ||
|
|
||
| <div class="hero__ipad-wrapper"> | ||
| <div class="hero__ipad"> |
Comment on lines
+62
to
+63
| <div class="features__list three-column-flex-sm-md-lg"> | ||
| <article class="features__item"> |
Owner
There was a problem hiding this comment.
Można też zrobić ul > li jako lista cech.
| </section> | ||
|
|
||
| <!-- Logos Section --> | ||
| <section class="logos text-center"> |
Owner
There was a problem hiding this comment.
Osobiście bym dał aside, bo to mało istotny dodatek.
| <div class="promo__media"> | ||
| <img class="promo__imac-screen scale-all" src="images/imac.png" alt="iMac Screen" /> | ||
| </div> | ||
| <div class="promo__content text-center text-left-sm-md-lg"> |
| margin-right: 15px; | ||
| } | ||
|
|
||
| @media (min-width: 768px) { |
Owner
There was a problem hiding this comment.
Fajnie, że od razu dostosowałeś to mniejszej rozdzielczości 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.