task-html-and-css-basics#173
Open
bartoszdudziak-dev wants to merge 9 commits intodevmentor-pl:masterfrom
Open
Conversation
devmentor-pl
approved these changes
Dec 18, 2024
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Bartku,
Całość prezentuje się bardzo dobrze! 👍
Miałem parę drobnych uwag dot. znaczników semantycznych, ale poza tym super!
| </nav> | ||
| </header> | ||
|
|
||
| <div class="container hero__container"> |
Owner
There was a problem hiding this comment.
Raczej zrobiłbym z tego article - jako spójna treść.
| </section> | ||
|
|
||
| <!-- LOGOS SECTION --> | ||
| <section class="logos"> |
Owner
There was a problem hiding this comment.
Może nawet aside bym zrobił bo to taka mało istotna treść.
| alt="iMac in light gray color" | ||
| /> | ||
| </div> | ||
| <div class="nova-theme__content"> |
| <!-- PRICING SECTION --> | ||
| <section id="pricing" class="pricing"> | ||
| <div class="container"> | ||
| <div class="pricing__header"> |
Owner
There was a problem hiding this comment.
Spokojnie bym zrobił header - ten znacznik może być użyty wew. article czy section i oznacza nagłówek dla takiego elementu.
| gap: 1rem; | ||
| padding-block: 1rem; | ||
| color: var(--primary-light-color); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.