Skip to content

Task done#168

Open
marazmlab wants to merge 2 commits intodevmentor-pl:masterfrom
marazmlab:master
Open

Task done#168
marazmlab wants to merge 2 commits intodevmentor-pl:masterfrom
marazmlab:master

Conversation

@marazmlab
Copy link
Collaborator

No description provided.

Copy link
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marku,

Całość prezentuje się bardzo dobrze! 👍
Zostawiłem parę drobnych uwag ;)

</head>
<body>
<section class="Main"> <!-- SECTION ------------------------------------------>
<header class="Main__header">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeśli to BEM to nie zaczynamy od wielkiej litery - wszystko z małej

<li class="Main__header__menu__item">
<a class="Main__header__menu__item__link" href="#">The team</a>
</li>
<li class="Main__header__menu__item">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jeśli to BEM to nie możemy w nieskończoność robić ... _ ... _ ... _ mamy tylko 2 zagłębienia tj. BLOCK__ELEMENT--MODIFIER - koniec ;P

</ul>
</header>
<section class="Main__content">
<div class="Main__content__left">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też wstatwić article zamiast div

Comment on lines +44 to +45
<div class="Features__header__box">
<div class="Features__header__box__card">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też zrobić ul > li bo to lista "cech"

Comment on lines +101 to +104
<p class="Price__box__card__text">
Up to 7 Projects <br>
2 Additional Developers <br>
</p>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tutaj zdecydowanie użyłbym ul > li - mamy listę cechy danego pakietu

<P class="Price__header__text">Pick any of our super affordable pricings</P>
</div>
<div class="Price__box">
<div class="Price__box__card">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Każdy z pakietów może też być article bo to jedna spójna całość

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants