Skip to content

Complete all tasks#68

Open
MstowskaSandra wants to merge 7 commits intodevmentor-pl:masterfrom
MstowskaSandra:master
Open

Complete all tasks#68
MstowskaSandra wants to merge 7 commits intodevmentor-pl:masterfrom
MstowskaSandra:master

Conversation

@MstowskaSandra
Copy link

No description provided.

Copy link
Owner

@devmentor-pl devmentor-pl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sandro,

Zadanka prezentują się super! 👍
Zostawiłem Ci zadanie dodatkowe ("variant") :)


import Alert from './../src/components/Alert';
import { Row, Col, Alert as RBAlert } from 'react-bootstrap';
const theme = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można też trzymać w osobnym pliku :)


import Button from './../src/components/Button';
import { Row, Col, Button as RBButton } from 'react-bootstrap';
export const theme = {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Można było wykorzystać jeden plik to wszystkich elementów ;)

</Col>
</Row>
);
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

</Col>
</Row>
);
};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

import { Row, Col, Card as RBCard, Button as RBButton } from "react-bootstrap";
import Button from "../src/components/Button/Button";
import { ThemeProvider } from "styled-components";
import { theme } from "../02/Task02";
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super!

};

export default Button;

No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

? theme.colors.primaryText
: theme.colors.secondaryText};
background-color: ${({ variant, theme }) =>
variant === "primary" ? theme.colors.primary : theme.colors.secondary};
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Czy da się zrobić to jakoś bardziej dynamicznie? Co jeśli tych "wariantów" jest 6? Nie będziemy każdego wariantu robić "na piechotę". Jak to zrobić dynamicznie?

border-radius: 0.25rem;
overflow: hidden;
background-color: #fff;
`; No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

);
};

export default Tabs; No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


export const TabPanel = styled.div`
padding: 0.75rem 0;
`; No newline at end of file
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments