Open
Conversation
devmentor-pl
approved these changes
Dec 15, 2023
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Maćku,
Całość prezentuje się bardzo dobrze! 👍
Parę drobnych uwag zostawiłem w komentarzach :)
01/Task01.js
Outdated
| </Row> | ||
| ) | ||
| } | ||
| const theme = { |
Owner
There was a problem hiding this comment.
Często wrzuca się do osobnego pliku ;)
02/Task02.js
Outdated
| </Row> | ||
| ) | ||
| } | ||
| const theme = { |
Owner
There was a problem hiding this comment.
Można mieć też jeden motyw dla całego projektu :)
| </Col> | ||
| </Row> | ||
| ); | ||
| }; |
src/components/Alert/Alert.js
Outdated
| } | ||
| const Alert = (props) => { | ||
| return ( | ||
| <ThemeProvider theme={props.theme || {}}> |
Owner
There was a problem hiding this comment.
Rozumiem, że to zadanie itp. ale docelowo Provider definiujemy gdzieś na górze hierarchii komponentów, aby wygodnie stylować przepływem theme - to tak na przyszłość
| color: #fff; | ||
| background-color: ${(props) => | ||
| props.theme[props.variant] || props.theme.default}; | ||
| `; |
| ); | ||
| }; | ||
|
|
||
| export default BreadcrumbItem; |
| } | ||
| `; | ||
|
|
||
| export { StyledBreadcrumbItem }; |
Comment on lines
22
to
26
| props.size === 'lg' && | ||
| css` | ||
| font-size: 18px; | ||
| padding: 1rem 1.5rem; | ||
| `} |
Owner
There was a problem hiding this comment.
Może wygodniej byłoby pobierać z theme tj. co na zasadzie props.theme[props.size]
| } | ||
| `; | ||
|
|
||
| export { StyledCard }; |
| ); | ||
| }; | ||
|
|
||
| export default Tabs; |
devmentor-pl
approved these changes
Dec 28, 2023
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Maćku,
Super, o to chodziło!
| <Alert variant="secondary"> | ||
| Uwaga! <em>Styled Components</em> nadchodzi! | ||
| </Alert> | ||
| </ThemeProvider> |
| </BreadcrumbItem> | ||
| <BreadcrumbItem active>Data</BreadcrumbItem> | ||
| </Breadcrumb> | ||
| </ThemeProvider> |
| </p> | ||
| </Tab> | ||
| <Tab eventKey="contact" title="Contact" disabled="disabled"> | ||
| <Tab eventKey="contact" title="Contact" disabled={true}> |
| <Button variant="primary" size="medium"> | ||
| Go somewhere | ||
| </Button> | ||
| </ThemeProvider> |
| size && theme.button[size].borderRadius}; | ||
| text-align: center; | ||
| font-size: 1rem; | ||
| font-size: ${({ size, theme }) => size && theme.button[size].fontSize}; |
| button: button, | ||
| }; | ||
|
|
||
| export default theme; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.