Open
Conversation
devmentor-pl
approved these changes
Sep 27, 2023
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Jedrzeju,
Zadania są jak najbardziej ok 👍
Zostawiłem Ci parę mniej istotnych uwag w komentarzach :)
| import Alert from './../src/components/Alert'; | ||
| import { Row, Col, Alert as RBAlert } from 'react-bootstrap'; | ||
| import { ThemeProvider } from 'styled-components'; | ||
| import themeSettings from '../src/components/Alert/theme' |
Owner
There was a problem hiding this comment.
Jeszcze lepszym rozwiązaniem jest mieć 1 motyw dla całej aplikacji i przekazywać ją w głównym komponencie np. App.js - teraz bym nie zmieniał, ale w projekcie bym to uwzględnił :)
| Library | ||
| </Breadcrumb.Item> | ||
| <Breadcrumb.Item active>Data</Breadcrumb.Item> | ||
| </Breadcrumb> |
| Button! | ||
| <ThemeProvider theme={themeSettings}> | ||
| <Button variant="primary" > Button!</Button> | ||
| </ThemeProvider> |
| <Tab eventKey="contact" name="Contact" disabled> | ||
| <p>Vivamus metus nulla, fermentum eget placerat vitae, mollis interdum elit. Pellentesque arcu augue, vulputate ut porttitor ut, suscipit non orci. Integer justo odio, suscipit eget tortor nec, molestie lobortis eros. Nullam commodo elit sit amet lacus blandit aliquet. Mauris at nibh eget nisl pulvinar dignissim.</p> | ||
| </Tab> | ||
| </Tabs> |
| <Button variant="primary"> Button!</Button> | ||
| </ThemeProvider> | ||
| </Card.Body> | ||
| </Card> |
|
|
||
|
|
||
| if (isDisabled) { | ||
| return css` |
Owner
There was a problem hiding this comment.
Można też return isDisabled && css...
| Body: Body, | ||
| Title: Title, | ||
| Text: Text, | ||
| }); |
| @@ -0,0 +1,16 @@ | |||
| import React from "react"; | |||
| import BreadcrumbItemStyled from "./BreadCrumbItemStyled"; | |||
Owner
There was a problem hiding this comment.
Tutaj niepotrzebnie C z wielkiej litery - na windows to nie problem, ale na linuxie (serwerze) już rzuca błędem :)
| } | ||
| `; | ||
|
|
||
| export default StyledTab; |
| ); | ||
| }; | ||
|
|
||
| export default Tabs; No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cześć, oddaję do sprawdzenia. Trochę utknąłem w ostatnim zadaniu przy cssie zmieniającym połozenie obrazka w zależności od propsa variant :/