Open
Conversation
devmentor-pl
approved these changes
Aug 31, 2023
Owner
devmentor-pl
left a comment
devmentor-pl
left a comment
There was a problem hiding this comment.
Marcinie,
Całość prezentuje się ok 👍
Zostawiłem Ci parę komentarzy.
Wprowadziłbym jedną zmianę dot. motywu - szczegóły w komentarzach :)
| import Alert from './../src/components/Alert'; | ||
| import { Row, Col, Alert as RBAlert } from 'react-bootstrap'; | ||
|
|
||
| // czy używanie css zamiast obiektu różni się czymś więcej niż tylko łatwością zapisu? |
Owner
There was a problem hiding this comment.
Na chwilę obecną nie przychodzi mi nic do głowy.
Chociaż zapis, który jest poniżej może być mniej optymalny pod względem szybkości działania (ale tylko po stronie develpmentu bo potem i tak wszystko webpack zamienia więc nie ma co się przejmować)
| ) | ||
| } | ||
| ); | ||
| }; |
| <Breadcrumb.Item href='#' active> | ||
| Data | ||
| </Breadcrumb.Item> | ||
| </Breadcrumb> |
| return <StyledBreadcrumb>{children}</StyledBreadcrumb>; | ||
| } | ||
|
|
||
| export default Breadcrumb; |
| border-radius: 0.25rem; | ||
| `; | ||
|
|
||
| export { StyledBreadcrumb }; |
| margin-bottom: 1rem; | ||
| `; | ||
|
|
||
| export { StyledCardBody, StyledCardTitle, StyledCardText }; |
| Title, | ||
| Body, | ||
| Text, | ||
| }); |
| animation: ${loadAnimation} 0.1s; | ||
| `; | ||
|
|
||
| export { StyledTab, StyledTabContent }; |
| ); | ||
| } | ||
|
|
||
| export default Tabs; |
| } | ||
| `; | ||
|
|
||
| export default GlobalStyle; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.