accept a channel for bot conduct #55
Conversation
jcbwlkr
left a comment
jcbwlkr
left a comment
There was a problem hiding this comment.
Thanks for doing this! I looked and yeah starting a DM to a user is a tad complicated so what you have here is good enough for now. I have a few tweaks below then we'll be good
scripts/conduct.js
Outdated
| // hubot conduct - Remind the channel about the devICT code of conduct | ||
|
|
||
| module.exports = (robot) => { | ||
| robot.respond(/(?:code(?: of)? )?conduct(?:\s?([#@][\w-]+))?/i, (msg) => { |
There was a problem hiding this comment.
If we aren't supporting DMs to a person then remove the @ from the regex
scripts/conduct.js
Outdated
| // None | ||
| // | ||
| // Commands: | ||
| // hubot conduct - Remind the channel about the devICT code of conduct |
There was a problem hiding this comment.
Please add an example of sending the conduct message to a particular channel
|
yay! I'm not sure how to actually test that it would send to the proper channel , but this partially came from an example and my regex capturing was working so I assume it's going to work lol |
blunket
force-pushed
the
ConductAcceptChannel
branch
from
163ad25 to
5362723
Compare
|
Is this still legit, or should we close it, being 2 years old now? |
|
I assume it'll still work. I figure the goal is just to allow someone to bot conduct a channel anonymously |
|
And when I said "I figure", that was before I realized there was an issue linked to this explaining just exactly that 😅 |
3 participants
doesn't do DMs, not sure how i'd do that.
switched to JS cause i'm more comfortable than i am in coffeescript
fix #35
just realized there's already a PR for this #55 woops :(