base: fix phandle resolution for vendor-prefixed DTS properties#732
Open
arthokal wants to merge 1 commit intodevicetree-org:masterfrom
Open
base: fix phandle resolution for vendor-prefixed DTS properties#732arthokal wants to merge 1 commit intodevicetree-org:masterfrom
arthokal wants to merge 1 commit intodevicetree-org:masterfrom
Conversation
DTS property names using a vendor prefix follow the convention <vendor>,<property> (e.g., xlnx,hdmi-connector and xlnx,xlnx-hdmi-acr-ctrl). The regex pattern used to detect property definitions during phandle resolution was restricted to the character class [a-zA-Z0-9_-], which excludes the comma character. As a result, any property whose name contains a vendor prefix was silently skipped, leaving its phandle references unresolved in the Lopper-generated pl.dtsi. Extend the character class to [a-zA-Z0-9_,-] to include the comma, allowing vendor-prefixed property names to be matched. This restores correct phandle resolution for properties such as xlnx,hdmi-connector and xlnx,xlnx-hdmi-acr-ctrl generated by SDT for HDMI-related PL IP blocks (e.g., xfmc and audio_ss_0_hdmi_acr_ctrl), bringing the Lopper output in line with the reference SDT-generated pl.dtsi. Signed-off-by: Aravind Thokala <aravind.thokala@amd.com>
Contributor
Author
|
@onkarharsh , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DTS property names using a vendor prefix follow the convention , (e.g., xlnx,hdmi-connector and xlnx,xlnx-hdmi-acr-ctrl). The regex pattern used to detect property definitions during phandle resolution was restricted to the character class [a-zA-Z0-9_-], which excludes the comma character. As a result, any property whose name contains a vendor prefix was silently skipped, leaving its phandle references unresolved in the Lopper-generated pl.dtsi.
Extend the character class to [a-zA-Z0-9_,-] to include the comma, allowing vendor-prefixed property names to be matched. This restores correct phandle resolution for properties such as xlnx,hdmi-connector and xlnx,xlnx-hdmi-acr-ctrl generated by SDT for HDMI-related PL IP blocks (e.g., xfmc and audio_ss_0_hdmi_acr_ctrl), bringing the Lopper output in line with the reference SDT-generated pl.dtsi.