fix: Return default value for OSPowerSavingState when device is power… #2277
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the power state endpoint to return a default value of 0 for OSPowerSavingState when the device is powered off or the value cannot be retrieved. The changes include refactoring code formatting across multiple files to improve readability by splitting long function calls across multiple lines.
Key changes:
- Modified
getPowerState.tsto handle null/missingOSPowerSavingStatevalues by defaulting to 0 - Added comprehensive test coverage for various error scenarios in
OSPowerSavingStateretrieval - Reformatted long function calls across multiple files for better readability
Reviewed changes
Copilot reviewed 8 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/routes/amt/getPowerState.ts | Fixed bug by returning default value of 0 for OSPowerSavingState when unavailable and simplified conditional logic |
| src/routes/amt/getPowerState.test.ts | Added four new test cases covering error scenarios, null responses, missing fields, and timeouts for OSPowerSavingState |
| src/utils/wsRedirect.test.ts | Reformatted long test assertions to multi-line format for improved readability |
| src/routes/devices/index.ts | Reformatted route definition to multi-line format |
| src/routes/amt/index.ts | Reformatted route definition to multi-line format |
| src/routes/amt/certificates/delete.ts | Reformatted find() predicate to multi-line format |
| src/routes/amt/certificates/delete.test.ts | Reformatted long test assertions to multi-line format |
| src/index.ts | Reformatted import statement and logger.warn call to multi-line format |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
madhavilosetty-intel
force-pushed
the
OSPowerSavingState
branch
from
ed9346b to
2587ec9
Compare
madhavilosetty-intel
force-pushed
the
OSPowerSavingState
branch
from
2587ec9 to
51eb271
Compare
2 tasks
RosieAMT
pushed a commit
that referenced
this pull request
Jan 5, 2026
## [2.25.3](v2.25.2...v2.25.3) (2026-01-05) ### Bug Fixes * Return default value for OSPowerSavingState when device is powered off ([#2277](#2277)) ([f7a0adf](f7a0adf))
|
🎉 This PR is included in version 2.25.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed off
PR Checklist
What are you changing?
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )