Skip to content

option to disable auto-updating of user.last_login during user login #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dieselmachine wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

option to disable auto-updating of user.last_login during user login #75

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions baph/auth/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
default_app_config = 'baph.auth.apps.AuthConfig'


def login(request, user):
def login(request, user, update_last_login=True):
'''Persist a user id and a backend in the request. This way a user doesn't
have to reauthenticate on every request.

Expand All @@ -26,8 +26,9 @@ def login(request, user):
user = request.user
# TODO: It would be nice to support different login methods, like signed
# cookies.
user.last_login = datetime.now()
session.commit()
if update_last_login:
user.last_login = datetime.now()
session.commit()

if SESSION_KEY in request.session:
if request.session[SESSION_KEY] != user.id:
Expand Down