chore(spec): refresh spec for launch sprint + qualified enum constants#20
Merged
Conversation
mono#369 adds MonitorStatus enum (UP/DOWN/DEGRADED/PAUSED/UNKNOWN) and IncidentFilterParamsSeverity (DOWN/DEGRADED), which causes oapi-codegen to namespace-qualify previously-unique enum constants: - generated.Email → generated.EmailChannelConfigChannelTypeEmail - generated.Down → generated.TriggerRuleSeverityDown - generated.Degraded → generated.TriggerRuleSeverityDegraded It also makes managedBy nullable on Create/Update DTOs (now *string pointer), and adds managedBy to Create/Update Status Page, Resource Group, and Alert Channel DTOs. Changes: - Refresh spec + regenerate types - Update enum constant references to qualified names - Wrap CreateMonitorRequest.ManagedBy in pointer (and similar for status page, resource group, alert channel) — provider continues to hardcode TERRAFORM for attribution - Allow-list new managed_by fields in schema-vs-DTO audit - Update monitor unit test for pointer ManagedBy Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks mono#369 launch sprint by handling spec changes that ripple
into TF provider source compilation.
mono#369 adds
MonitorStatusenum (UP/DOWN/DEGRADED/PAUSED/UNKNOWN) andIncidentFilterParamsSeverity(DOWN/DEGRADED), which causes oapi-codegento namespace-qualify previously-unique enum constants:
generated.Email→generated.EmailChannelConfigChannelTypeEmailgenerated.Down→generated.TriggerRuleSeverityDowngenerated.Degraded→generated.TriggerRuleSeverityDegradedIt also makes
managedBynullable onCreateMonitorRequest(now*pointer), and addsmanagedByto Create/Update Status Page, ResourceGroup, and Alert Channel DTOs.
Changes
docs/openapi/monitoring-api.jsonfrom mono#369internal/generated/types.goCreateMonitorRequest.ManagedByin pointer (and similar forstatus page, resource group, alert channel) — provider continues to
hardcode
TERRAFORMfor attribution so audit trail is correctmanaged_byfields in schema-vs-DTO auditmonitor_test.gofor pointerManagedBycomparisonWhy now
mono#369 Evolution Harness pulls TF provider source from
mainandrecompiles against the new spec. Without this PR, mono#369 cannot merge.
Cross-repo dependency: this PR must merge first.
Test plan
go build ./...(clean locally)go test ./...(clean locally — all 4 packages pass)same wire format)
Made with Cursor