fix(status_page): return correct devhelmstatus.com domain in page_url#18
Merged
Conversation
The provider was returning <slug>.devhelm.page which doesn't resolve; actual public host is <slug>.devhelmstatus.com. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
devhelm_status_page.page_urlreturnedhttps://<slug>.devhelm.page, which is a domain that does not resolve. The actual public host for DevHelm-hosted status pages ishttps://<slug>.devhelmstatus.com.Found during DevEx round 3.
Repro
Before this fix:
After:
Fix
page_urlis computed entirely client-side fromslug(the API does not return it; see comment inmapToState). Swap the hard-coded host literaldevhelm.page→devhelmstatus.comeverywhere it appears:internal/provider/resources/status_page.go—mapToStateformat string + schema description + commentinternal/provider/datasources/status_page.go—mapStatusPageToStateformat stringtemplates/guides/getting-started.md.tmpldocs/resources/status_page.mdanddocs/guides/getting-started.mdviamake docsScope
Fix is provider-side only.
StatusPageDtodoes not expose apageUrlfield — the URL is synthesized in the provider, so the wrong host never came from the API. No mono-side change is required.Validation
go build ./...✓go vet ./...✓go test ./...✓ (all package suites pass)make docs-check✓ (clean tree after regen)Diff stat
No version bump in this PR — will be cut after merge.
Made with Cursor