Skip to content

fix(status_page): return correct devhelmstatus.com domain in page_url#18

Merged
caballeto merged 1 commit into
mainfrom
fix/status-page-url-domain
May 5, 2026
Merged

fix(status_page): return correct devhelmstatus.com domain in page_url#18
caballeto merged 1 commit into
mainfrom
fix/status-page-url-domain

Conversation

@caballeto
Copy link
Copy Markdown
Member

Bug

devhelm_status_page.page_url returned https://<slug>.devhelm.page, which is a domain that does not resolve. The actual public host for DevHelm-hosted status pages is https://<slug>.devhelmstatus.com.

Found during DevEx round 3.

Repro

resource "devhelm_status_page" "p" {
  name = "Acme Status"
  slug = "acme"
}

output "url" { value = devhelm_status_page.p.page_url }

Before this fix:

url = "https://acme.devhelm.page"   # NXDOMAIN

After:

url = "https://acme.devhelmstatus.com"   # resolves to the public status page

Fix

page_url is computed entirely client-side from slug (the API does not return it; see comment in mapToState). Swap the hard-coded host literal devhelm.pagedevhelmstatus.com everywhere it appears:

  • internal/provider/resources/status_page.gomapToState format string + schema description + comment
  • internal/provider/datasources/status_page.gomapStatusPageToState format string
  • All four corresponding unit-test expectations
  • Templated example output in templates/guides/getting-started.md.tmpl
  • Regenerated docs/resources/status_page.md and docs/guides/getting-started.md via make docs

Scope

Fix is provider-side only. StatusPageDto does not expose a pageUrl field — the URL is synthesized in the provider, so the wrong host never came from the API. No mono-side change is required.

Validation

  • go build ./...
  • go vet ./...
  • go test ./... ✓ (all package suites pass)
  • make docs-check ✓ (clean tree after regen)

Diff stat

 docs/guides/getting-started.md                            | 2 +-
 docs/resources/status_page.md                             | 2 +-
 internal/provider/datasources/datasources_test.go         | 2 +-
 internal/provider/datasources/negative_datasource_test.go | 2 +-
 internal/provider/datasources/status_page.go              | 2 +-
 internal/provider/resources/negative_validation_test.go   | 2 +-
 internal/provider/resources/status_page.go                | 8 ++++----
 internal/provider/resources/status_page_test.go           | 2 +-
 templates/guides/getting-started.md.tmpl                  | 2 +-
 9 files changed, 12 insertions(+), 12 deletions(-)

No version bump in this PR — will be cut after merge.

Made with Cursor

The provider was returning <slug>.devhelm.page which doesn't resolve;
actual public host is <slug>.devhelmstatus.com.

Co-authored-by: Cursor <cursoragent@cursor.com>
@caballeto caballeto merged commit f41be6b into main May 5, 2026
6 checks passed
@caballeto caballeto deleted the fix/status-page-url-domain branch May 5, 2026 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant