Add a playback_ready field to the "/" api response#298
Open
dubeyKartikay wants to merge 1 commit intodevgianlu:masterfrom
Open
Add a playback_ready field to the "/" api response#298dubeyKartikay wants to merge 1 commit intodevgianlu:masterfrom
dubeyKartikay wants to merge 1 commit intodevgianlu:masterfrom
Conversation
|
could this be emitted as a event toi? |
Author
|
Actually that's a great idea, I'll make the changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to test the
/player/playendpoint. I ran into a bug where the app would say that "its up" ( GET "/" and "/status" would return 200) but when i hit the/player/playendpoint, the playback would fail.sometimes the connection id was not set, sometimes the volume sync hadn't happened, which led to the volume of the track changing mid playback.
So i had to expose a
playback_readyfield that is set totruewhenever its safe to call/player/playandfalseotherwise