Skip to content

Disable setAllowFileAccess in WebViewActivity #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jim-daf wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Disable setAllowFileAccess in WebViewActivity #390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/com/gianlu/aria2app/webview/WebViewActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,13 @@ protected void onCreate(Bundle savedInstanceState) {

WebSettings settings = web.getSettings();
settings.setJavaScriptEnabled(true);
settings.setAllowFileAccess(true);
// The WebView is used to browse the web for downloadable links and
// hand them off to aria2. shouldInterceptRequest below routes every
// request through an OkHttpClient that only handles http and https
// (HttpUrl.parse returns null for file:// URIs and the request is
// dropped). file:// inputs are not a supported use case here, so
// there is no reason to leave the default file-access surface on.
settings.setAllowFileAccess(false);
settings.setDomStorageEnabled(true);
settings.setDatabaseEnabled(true);

Expand Down