refactor: store slices #252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gadomski
requested changes
Jan 20, 2026
Collaborator
gadomski
left a comment
gadomski
left a comment
There was a problem hiding this comment.
Cool, makes sense to me ... definetly makes the store more readable. Looks like there's a couple lints, but otherwise LGTM.
Contributor
Author
|
@gadomski updated! |
gadomski
approved these changes
Jan 21, 2026
Collaborator
|
LGTM! Happy to merge when you're ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gadomski what do you think about store slices? Its just pure organization so feel free to disagree! I just find it nice versus a big state store file.