Poetry error message #852
Merged
Poetry error message #852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
requested changes
Jul 3, 2024
samruddhikhandale
requested changes
Jul 5, 2024
samruddhikhandale
previously requested changes
Jul 8, 2024
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Let's wait for another review from @chrmarti. Thanks!
prathameshzarkar9
force-pushed
the
poetry-error-message
branch
from
bdb9496 to
d7c7585
Compare
chrmarti
requested changes
Jul 9, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Left a comment, maybe the error handling should move up a few lines. Thanks.
chrmarti
requested changes
Jul 17, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks @prathameshzarkar9! I have left a few comments.
Contributor
Author
|
@chrmarti , can you please review the requested changes |
chrmarti
requested changes
Jul 29, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
A few more comments and some message polishing.
prathameshzarkar9
force-pushed
the
poetry-error-message
branch
from
d5afcad to
8dc040c
Compare
Member
|
@prathameshzarkar9 Can you fix the failing tests? Thanks |
prathameshzarkar9
force-pushed
the
poetry-error-message
branch
from
4519be8 to
0805d6f
Compare
prathameshzarkar9
force-pushed
the
poetry-error-message
branch
from
fe6788e to
be1fbd7
Compare
|
@chrmarti Could you please review this PR .. |
chrmarti
requested changes
Nov 13, 2024
Contributor
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Left two more comments.
chrmarti
dismissed
samruddhikhandale’s stale review
All comments were addressed.
chrmarti
approved these changes
Nov 21, 2024
eljog
approved these changes
Nov 21, 2024
josephjsteen1
pushed a commit
to josephjsteen1/cli
that referenced
this pull request
Oct 24, 2025
* testing the usecase * error message thrown for the command not found * semicolon was missing * unwanted changes reverted and also added command output for the error * review comments addressed * moved the cmdOutput to runRemoteCommand function for all the commands * refactored code and moved outer catch block to inner catch block * try catch block added for per lifecycleHook * await promise changes * test case fixed * unwanted code removed * file name changed * Fixes --------- Co-authored-by: Christof Marti <chrmarti@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #845
infoOutput has been updated and logged the message of the command if the command fails inside container