Skip to content

Fix nanolayer installation in gh-release feature#224

Open
nkaaf wants to merge 1 commit into
devcontainers-extra:mainfrom
nkaaf:fix_nanolayer_installation_in_gh_release
Open

Fix nanolayer installation in gh-release feature#224
nkaaf wants to merge 1 commit into
devcontainers-extra:mainfrom
nkaaf:fix_nanolayer_installation_in_gh_release

Conversation

@nkaaf
Copy link
Copy Markdown

@nkaaf nkaaf commented May 20, 2026

This should fix the issue #216

Updates gh-release feature to 1.0.27

I was lazy and copied the ensure_nanolayer function of the ruff feature. I just bumped the version, because this would be cool to have in a new version.

Following notices I found during this copy:

  1. After this is merged, I think that it will be good to unify clean_download and ensure_nanolayer functions in all features, because new features are just copied from existing ones, based on experience.
  2. Due to the fact that some syntax is not POSIX-compliant, the shebang of each library_scripts.sh file has to be bash-compliant. Either the scripts are build POSIX-compliant to be executable with sh (bash is not installed in alpine images) or raw alpine base images cannot execute any feature.
  3. Some Features use older versions of nanolayer, maybe these should be updated/migrated?

If you like these points, feel free to create issues and tag me. I'd be interested in creating pull requests for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant