Fix nanolayer installation in gh-release feature#224
Open
nkaaf wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix the issue #216
Updates
gh-releasefeature to1.0.27I was lazy and copied the
ensure_nanolayerfunction of therufffeature. I just bumped the version, because this would be cool to have in a new version.Following notices I found during this copy:
clean_downloadandensure_nanolayerfunctions in all features, because new features are just copied from existing ones, based on experience.library_scripts.shfile has to bebash-compliant. Either the scripts are build POSIX-compliant to be executable withsh(bash is not installed in alpine images) or raw alpine base images cannot execute any feature.If you like these points, feel free to create issues and tag me. I'd be interested in creating pull requests for them.