fix: Bun Feature Failure on Apple Silicon ARM64 + Feature Hardening#149
Conversation
|
Would appreciate a review + merge on this to clear the related issue |
|
Hi Trevor! Thanks for your PR, and sorry for the delay with the review, I'm being busy lately. I'm going to review it by the end of this week |
koralowiec
left a comment
There was a problem hiding this comment.
To be honest, I think that there's too much logging, and maybe too much logic in some places.
Generally, the solution which you provided looks nice, but I would like to get rid of the logging part. So please remove the log and debug_log functions, and their execution. If you feel something has to be output, use echo for now.
Like I mentioned in one of the comments, I'm going to think about adding the logging functions to the shared script (#165)
|
@trevordcampbell possible to get these changes as advised in so it can be merged up and released? Thankful for your contribution - eager to drop workarounds! |
Co-authored-by: Cursor <cursoragent@cursor.com>
2fd562b to
058d31c
Compare
|
I just pushed the requested changes to the Bun feature. Hopefully should be ready to ship now. Apologies for the delay |
koralowiec
left a comment
There was a problem hiding this comment.
Please change the bun version in the test
Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com> Signed-off-by: Trevor Campbell <55037769+trevordcampbell@users.noreply.github.com>
Co-authored-by: Arek Kalandyk <36413794+koralowiec@users.noreply.github.com> Signed-off-by: Trevor Campbell <55037769+trevordcampbell@users.noreply.github.com>
|
Should be good to go now |
Problem
The Bun feature failed to install on Apple Silicon Mac hosts when creating
arm64Linux containers.Users encountered this error:
no matches found for asset regex: ^bun-linux-aarch64-baseline\.zip$Root Cause
The Bun feature was attempting to download
bun-linux-aarch64-baseline.zip, but Bun does not publish"baseline" variants for the ARM64 architecture. For linux /
arm64, Bun only publishes:bun-linux-aarch64.zip(glibc)bun-linux-aarch64-musl.zip(musl)This worked on linux /
amd64-based DevContainers because baseline variants exist there, but failed onarm64-based DevContainers.Solution
1.
arm64Asset Pattern Fixarm64now uses standard builds instead of non-existent baseline variants2. Comprehensive Feature Enhancements
Robust libc Detection
/sbin/apkcheck to 4 detection methods:ldd --versionoutput analysis/proc/mountsanalysis/proc/mountsmusl check to avoid broken grep pipelineEnhanced Architecture Support
aarch64andarm64aliasesBetter Error Handling & Diagnostics
Improved Logging & User Experience
[2024-01-15 10:30:15] INFO: ...INFO,SUCCESS,WARNING,ERRORBUN_FEATURE_DEBUG=1Performance Optimizations
Version Handling Enhancements
1.2.3,v1.2.3,bun-v1.2.3Benefits
For Apple Silicon Users
arm64asset selectionFor All Users
Files Changed
src/bun/install.shsrc/bun/NOTES.mdarm64supportTesting
References