ci: adopt GitHub Code Quality coverage in ci-go (drop Codecov)#4893
Open
devantler wants to merge 5 commits into
Open
ci: adopt GitHub Code Quality coverage in ci-go (drop Codecov)#4893devantler wants to merge 5 commits into
devantler wants to merge 5 commits into
Conversation
![ksail-bot[bot]](https://avatars.githubusercontent.com/in/2880167?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the repository-side migration away from Codecov by updating the ci-go push-to-main workflow call to use the reusable workflow version that reports coverage via GitHub Code Quality, and by removing the remaining Codecov references in the repo.
Changes:
- Bump
validate-go-project.yamlreusable workflow reference from v3.1.4 to v4.0.0. - Update
ci-gojob permissions to includecode-quality: writeand remove theCODECOV_TOKENsecret passthrough. - Remove the Codecov badge from the README.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| README.md | Removes the Codecov badge now that Codecov is no longer used. |
| .github/workflows/ci.yaml | Updates the ci-go reusable workflow version, adds required code-quality: write permission, and drops CODECOV_TOKEN. |
Contributor
❌MegaLinter analysis: Error❌ COPYPASTE / jscpd - 7 errors❌ REPOSITORY / osv-scanner - 1 error❌ ACTION / zizmor - 1 error✅ Linters with no issuesactionlint, bash-exec, git_diff, hadolint, jsonlint, lychee, markdown-table-formatter, markdownlint, prettier, prettier, shellcheck, shfmt, stylelint, syft, trivy-sbom, trufflehog, v8r, v8r, yamllint Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.50.
| Benchmark suite | Current: a894792 | Previous: b60e971 | Ratio |
|---|---|---|---|
BenchmarkCluster_MarshalYAML/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
198134 ns/op 18369 B/op 442 allocs/op |
75769 ns/op 18368 B/op 442 allocs/op |
2.61 |
BenchmarkCluster_MarshalYAML/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
198134 ns/op |
75769 ns/op |
2.61 |
BenchmarkCluster_MarshalYAML/WithBasicConfig (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
201076 ns/op 18368 B/op 442 allocs/op |
122067 ns/op 18368 B/op 442 allocs/op |
1.65 |
BenchmarkCluster_MarshalYAML/WithBasicConfig (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
201076 ns/op |
122067 ns/op |
1.65 |
BenchmarkCluster_MarshalYAML/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
214071 ns/op 21592 B/op 473 allocs/op |
133913 ns/op 21592 B/op 473 allocs/op |
1.60 |
BenchmarkCluster_MarshalYAML/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
214071 ns/op |
133913 ns/op |
1.60 |
BenchmarkCluster_MarshalJSON/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
201541 ns/op 18581 B/op 448 allocs/op |
117904 ns/op 18580 B/op 448 allocs/op |
1.71 |
BenchmarkCluster_MarshalJSON/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
201541 ns/op |
117904 ns/op |
1.71 |
BenchmarkCluster_MarshalJSON/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
240209 ns/op 24659 B/op 547 allocs/op |
85388 ns/op 24649 B/op 547 allocs/op |
2.81 |
BenchmarkCluster_MarshalJSON/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
240209 ns/op |
85388 ns/op |
2.81 |
BenchmarkYAMLEncode/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
225118 ns/op 25304 B/op 470 allocs/op |
66926 ns/op 25304 B/op 470 allocs/op |
3.36 |
BenchmarkYAMLEncode/Minimal (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
225118 ns/op |
66926 ns/op |
3.36 |
BenchmarkYAMLEncode/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
292129 ns/op 36432 B/op 515 allocs/op |
74118 ns/op 36432 B/op 515 allocs/op |
3.94 |
BenchmarkYAMLEncode/FullProductionCluster (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
292129 ns/op |
74118 ns/op |
3.94 |
BenchmarkJSONEncode (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
210873 ns/op 19820 B/op 466 allocs/op |
64859 ns/op 19816 B/op 466 allocs/op |
3.25 |
BenchmarkJSONEncode (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
210873 ns/op |
64859 ns/op |
3.25 |
BenchmarkPruneClusterDefaults/MostlyDefaults (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) |
63180 ns/op 9792 B/op 265 allocs/op |
30949 ns/op 9792 B/op 265 allocs/op |
2.04 |
BenchmarkPruneClusterDefaults/MostlyDefaults (github.com/devantler-tech/ksail/v7/pkg/apis/cluster/v1alpha1) - ns/op |
63180 ns/op |
30949 ns/op |
2.04 |
BenchmarkProgressGroup_NoOp (github.com/devantler-tech/ksail/v7/pkg/notify) |
15875 ns/op 2816 B/op 58 allocs/op |
10130 ns/op 2816 B/op 58 allocs/op |
1.57 |
BenchmarkProgressGroup_NoOp (github.com/devantler-tech/ksail/v7/pkg/notify) - ns/op |
15875 ns/op |
10130 ns/op |
1.57 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Updates the
ci-gocaller (the push-to-mainvalidate-go-projectinvocation) for the coverage migration:validate-go-project.yamlfromv3.1.4→v4.0.0(GitHub Code Quality coverage; Codecov removed).code-quality: writeto the job — required byv4.0.0, or the reusable-workflow run fails at startup.CODECOV_TOKENsecret passthrough (the org secret has been deleted; the Codecov app is uninstalled).Coverage on PRs already runs via the org ruleset (
validate-go-project@main); this aligns the repo's own push-to-mainci-gojob and removes its last Codecov dependency.🤖 Generated with Claude Code