fix: close TSL post-merge follow-ups#61
Closed
devallibus wants to merge 4 commits intodevelopmentfrom
Closed
Conversation
Implements discriminated union on `language` field throughout schema, registry, CLI, MCP, and playground to support TSL shaders alongside GLSL. Schema (0.1.0 → 0.2.0): - Discriminated union: GLSL (files: vertex+fragment) / TSL (tslEntry) - Add `node-material` to compatibility material enum - Language defaults to "glsl" for backward compatibility Registry (0.1.0 → 0.2.0): - Index entries include `language` field - Bundles: GLSL (vertexSource+fragmentSource) / TSL (tslSource) - Builder handles both manifest shapes CLI: - `add` writes source.ts for TSL, vertex+fragment.glsl for GLSL - `search` gains `language` filter MCP: - Tools updated with language/tslSource parameters - search_shaders, create_playground, update_shader accept language Playground: - Session types: language, tslSource, structuredErrors fields - DB migration: shader_language, tsl_source, structured_errors_json - API routes handle TSL create/update/errors - UI: language-aware tabs (source.ts vs vertex/fragment.glsl) - Canvas: TSL placeholder (WebGPU preview in follow-up) Corpus: - First TSL shader: tsl-gradient-wave (animated gradient with NodeMaterial) - Existing GLSL shaders bumped to schemaVersion 0.2.0 Closes #56 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ShaderDetail is now a discriminated union (GlslShaderDetail |
TslShaderDetail), matching the PlaygroundSession pattern. The web
detail page, loadShaderDetail, and registry-backed source loader all
branch on language to read the correct source files and render the
appropriate UI.
Playground session creation now rejects invalid language strings
(anything other than "glsl" or "tsl") with a descriptive error. MCP
tool schemas constrain the language parameter to an enum.
Fixes:
- /shaders/tsl-gradient-wave no longer crashes (was TypeError on
manifest.files.vertex)
- createSession({ language: "foo" }) now throws instead of silently
creating a malformed session
6 new tests cover TSL detail loading and invalid language rejection.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- fix the TSL shader detail page for both filesystem-backed and registry-backed detail loading\n- reject invalid playground language values and constrain MCP language schemas\n- add coverage for the registry-backed shader detail branches\n\n## Validation\n- bun run test:web\n- bun x tsc -p tsconfig.json --noEmit\n- bun run build:web