-
Notifications
You must be signed in to change notification settings - Fork 30
Fixes listed issues & Major UI/UX improvements. #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SmokeHound
wants to merge
117
commits into
devadvance:master
Choose a base branch
from
SmokeHound:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Fix app breaking when using settings after loading data
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
[WIP] Improve styles and enhance overall user experience
Removed redundant issue reporting instructions and improved clarity.
- Updated Angular dependencies to version 21.x in package.json. - Removed deprecated HttpModule and replaced it with HttpClientModule. - Changed build command to non-production mode for easier development. - Added standalone property to components and pipes for better modularity. - Refactored service methods to return more specific Promise types. - Updated TypeScript configuration files for improved type checking and compatibility. - Removed environment checks in main.ts for simplified bootstrapping.
- Removed zone.js references from angular.json, package.json, and package-lock.json. - Updated main.ts to use platformBrowser instead of platformBrowserDynamic. - Changed component metadata to include standalone: false where applicable. - Refactored promise return types in SmsStoreService and VcfStoreService for consistency. - Updated test.ts to use the new testing imports from Angular.
- Updated .gitignore to exclude Angular CLI/Vite caches. - Modified DEVELOPING.md to reflect new testing commands using Vitest. - Updated angular.json to configure unit tests to use Vitest as the runner. - Removed Protractor end-to-end test files and configurations. - Deleted Karma configuration and related files. - Updated package.json to change test scripts for Vitest compatibility. - Refactored component and service test files to align with Vitest standards. - Added vitest.setup.ts and vitest.config.ts for Vitest setup and configuration. - Updated environment.ts comments to reflect changes in Angular CLI configuration.
…ry (#4) * Initial plan * Update README and Travis CI config with correct repository references Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
This was referenced Jan 13, 2026
* Initial plan * Add export options dialog component with field and scope selection Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com> * Improve TypeScript type safety in export options dialog Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: SmokeHound <23314326+SmokeHound@users.noreply.github.com>
… and functionality
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…g in message list
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…e fetching performance
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…ative file saving
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…unctionality - Implemented XMLParser class to parse XML data into JavaScript objects with validation options. - Added node2json module to prettify and compress parsed XML data. - Created XmlNode class to represent XML nodes with attributes and children. - Introduced strnum module for parsing strings into numbers with various configurations. - Added tests for strnum functionality to ensure correct parsing behavior. - Updated package.json and package-lock.json for new dependencies and project setup.
- Introduced BufferSource and StringSource classes for handling byte and string inputs respectively. - Implemented EntitiesParser for managing HTML entities and custom entity replacements. - Added booleanParser and booleanParserExt for flexible boolean value parsing. - Created currency parser to handle various currency formats. - Implemented join function for joining array elements into a string. - Added number parser for converting strings to numbers. - Introduced trimmer class for trimming whitespace from strings. - Established new output builders (JsArrBuilder, JsMinArrBuilder) for structured output generation. - Enhanced options management with OptionsBuilder for better configuration handling. - Added support for character symbols in XML parsing with CharsSymbol.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…riptions for clarity
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the user interface and user experience of the SMS Backup Reader app, with significant enhancements to styling, usability, and performance. The most important changes include a major UI/UX refresh across multiple components, improved handling of large message backups to prevent UI freezing, and several bug fixes and minor improvements.
UI/UX Improvements:
src/app/app.component.css,src/app/main/main.component.css,src/app/settings/settings.component.css,src/app/contact-list/contact-list.component.css,src/app/message-list/message-list.component.css,src/app/sms-loader/sms-loader.component.css,src/app/vcf-loader/vcf-loader.component.css) [1] [2] [3] [4] [5] [6]src/app/main/main.component.html,src/app/settings/settings.component.html,src/app/contact-list/contact-list.component.html,src/app/message-list/message-list.component.html,src/app/sms-loader/sms-loader.component.html,src/app/vcf-loader/vcf-loader.component.html) [1] [2] [3] [4] [5] [6]Performance and Data Handling:
src/app/sms-store.service.ts) [1] [2] [3]src/app/country-select/country-select.component.ts)src/app/country-select/country-select.component.ts)Minor Fixes and Improvements:
src/app/main/main.component.ts)src/app/country-select/country-select.component.css,src/app/country-select/country-select.component.html) [1] [2]README.md)Bug Fixes:
src/app/sms-store.service.ts,src/app/vcf-store.service.ts) [1] [2]These changes collectively make the app more visually appealing, responsive, and user-friendly, especially for users with large SMS backups.