Skip to content

Reworked Inspector#2

Closed
Sima214 wants to merge 7 commits into
dev-lab:mainfrom
Sima214:main
Closed

Reworked Inspector#2
Sima214 wants to merge 7 commits into
dev-lab:mainfrom
Sima214:main

Conversation

@Sima214
Copy link
Copy Markdown

@Sima214 Sima214 commented May 6, 2026

Notably:

  • Added preview of bom nodes.
  • Changed node hit detection logic to now match the visual shape.
  • Added the ability to draw traces.
    You can start a new trace with right click, new segment with left and end it with right.
    This input scheme is probably not intuitive, I am willing to refine it based on feedback and my own experience using it the following days (https://gitlab.com/Sima214/good-old-laser-printer).

@dev-lab
Copy link
Copy Markdown
Owner

dev-lab commented May 7, 2026

Thanks for the contribution and the time you put into this PR.

I tested it against the current application behavior and unfortunately it introduces a regression in Inspector that prevents inspecting (viewing) net nodes across all opened layers. It also changes some UI behavior/colors and adds functionality that is outside the direction I currently want for the project.

While I do plan to show other nets later (when I have more time), I never intended to support manual trace drawing. My goal is to keep trace generation automatic, even if the generated traces do not exactly correspond to the existing PCB layout, please refer to the PcbVisualizer part of the underlying WireBender library.

Because of that, I’m not going to merge this PR.

I still appreciate the effort and your interest in contributing.

@dev-lab dev-lab closed this May 7, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators May 7, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants