feat(fga): add fgacacheurl parameter for cache proxy support #642
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes descope/etc#13458
View workflow run
Excellent! All tests are passing now, including the commonjs test. Let me create a summary of the changes:
Summary
I've successfully implemented FGACacheURL support in the node-sdk, mirroring the Python SDK implementation from PR #656. Here's what was done:
Changes Made:
Added
fgaCacheUrlconfiguration parameter (lib/index.ts):NodeSdkArgstypeUpdated management module (
lib/management/index.ts):FGAConfigtype to pass FGA configurationwithManagementto accept and pass FGA configModified FGA module (
lib/management/fga.ts):FGAConfigtype withfgaCacheUrl,managementKey,projectId, andheaderspostWithOptionalCachehelper function that:saveSchemacreateRelationsdeleteRelationscheckAdded comprehensive tests (
lib/management/fga.test.ts):saveSchemacreateRelationsdeleteRelationscheckUpdated documentation (
README.md):Key Features:
fgaCacheUrlis not provided, all FGA operations work exactly as beforesaveSchema,createRelations,deleteRelations,check) use the cache; other operations continue using the standard APITest Results:
The implementation is complete and ready for use!
Created by Shuni 🐕