Skip to content

chore: remove unused properties and schemas#8378

Open
chadlwilson wants to merge 2 commits intodependency-check:mainfrom
chadlwilson:remove-unused-schemas
Open

chore: remove unused properties and schemas#8378
chadlwilson wants to merge 2 commits intodependency-check:mainfrom
chadlwilson:remove-unused-schemas

Conversation

@chadlwilson
Copy link
Collaborator

@chadlwilson chadlwilson commented Mar 19, 2026

Description of Change

Some minor tidies

  • removes unused properties default values
  • deprecates the constants that referenced them (and some others without defaults); annotated with the ODC version they became dereferenced
  • removes some old schema documents that are no longer used by or relevant to ODC itself (some have been moved to open-vulnerability-clients)

Have test cases been added to cover the new functionality?

N/A

These are no longer used anywhere.

Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
These were either removed a long time ago (CPE schema); or logic moved to open-vulnerability-clients so no longer should need to be maintained/distributed with ODC core.

Signed-off-by: Chad Wilson <29788154+chadlwilson@users.noreply.github.com>
@boring-cyborg boring-cyborg bot added core changes to core documentation site documentation tests test cases utils changes to utils labels Mar 19, 2026
@chadlwilson chadlwilson requested a review from Copilot March 19, 2026 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR performs cleanup of Dependency-Check configuration artifacts by removing unused default properties, marking corresponding settings keys as deprecated, and deleting legacy schema resources that are no longer referenced by ODC.

Changes:

  • Remove unused default entries from dependencycheck.properties (main + test resources).
  • Deprecate no-longer-used settings keys in Settings.KEYS with forRemoval metadata.
  • Remove legacy NVD/CPE schema documents and a stale commented-out NVD generation block from core/pom.xml.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.

Show a summary per file
File Description
utils/src/test/resources/dependencycheck.properties Drops unused proxy.disableSchemas and CPE defaults from utils test config.
utils/src/main/java/org/owasp/dependencycheck/utils/Settings.java Deprecates unused settings constants (CPE, proxy schema disable, vfeed, downloader legacy keys).
core/src/test/resources/dependencycheck.properties Drops unused proxy.disableSchemas and CPE defaults from core test config.
core/src/site/resources/images/readme.txt Removes an obsolete readme file under site images.
core/src/main/resources/schema/external/nvd/nvd_cve_feed_json_1.1.schema Deletes unused legacy NVD JSON schema resource.
core/src/main/resources/schema/external/nvd/cvss-v3.x.json Deletes unused legacy CVSS v3 schema resource.
core/src/main/resources/schema/external/nvd/cvss-v2.0.json Deletes unused legacy CVSS v2 schema resource.
core/src/main/resources/schema/external/nvd/CVE_JSON_4.0_min_1.1.schema Deletes unused legacy CVE JSON schema resource.
core/src/main/resources/schema/external/cpe/cpe-dictionary_2.2.xsd Deletes unused legacy CPE dictionary XSD resource.
core/src/main/resources/dependencycheck.properties Drops unused proxy.disableSchemas and CPE defaults from main core config.
core/src/main/doc/schema/nvdcve/json/nvd_cve_feed_json_1.1.schema Deletes unused legacy schema doc copy.
core/src/main/doc/schema/nvdcve/json/cvss-v3.x.json Deletes unused legacy schema doc copy.
core/src/main/doc/schema/nvdcve/json/cvss-v2.0.json Deletes unused legacy schema doc copy.
core/src/main/doc/schema/nvdcve/json/CVE_JSON_4.0_min_1.1.schema Deletes unused legacy schema doc copy.
core/pom.xml Removes a stale commented-out generate-nvd jsonschema2pojo execution block.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core changes to core documentation site documentation tests test cases utils changes to utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants