fix: Correct published/hosted suppressions namespace header and indent

[chadlwilson]

Description of Change

URGENT: #8254 had a missing trailing quote in the syntax for creating the published suppressions so the current published file is not well formed XML and will be failing. Gulp.

I was deliberately testing it via #8257 (it's a real FP) to make sure it was OK, and noticed I'd broken it.

This PR should fix it (and tweak the indents slightly; as I hadn't noticed an else block in the approvals workflow)

See https://dependency-check.github.io/DependencyCheck/suppressions/publishedSuppressions.xml

Generated suppressions - ✅ 8750da5
Published suppressions - ❌ 593b647

Related issues

• fixes False positives caused by being unable to parse the hosted suppressions data file since 27 Jan 16:14 UTC #8259

Have test cases been added to cover the new functionality?

no

[chadlwilson]

If @jeremylong or @nhumblot are around a quick review and/or merge would be appreciated, since the hosted suppressions are currently broken (by me) 😬😬

[nhumblot]

Hi @chadlwilson

Thank you very much for preparing this PR! I just checked from my phone. Looks ok to me, I'm going to merge. If things continue to not work, I can look at it in a few hours

[nhumblot]

TODO (action @nhumblot ): create a task to see how we can improve our validation in the CI

[chadlwilson]

Yeah … xml inside JavaScript inside yaml isn’t exactly the best DevEx 😄

[chadlwilson]

Created #8260 to verify (and correct the published file.

Looks ok now.

generated: cecc46d

published: 571286c

[chadlwilson]

TODO (action @nhumblot ): create a task to see how we can improve our validation in the CI

Assuming GitHub script is the way forward, probably best to at least source control all of the GitHub script content separately as JS files: https://github.com/actions/github-script?tab=readme-ov-file#run-a-separate-file

That way you avoid the yaml indent problems; can get IDE support for the JS (and probably XMl-in-a-string) as well as theoretically write unit tests for the GitHub script, with some mocking/stubbing, and even factor out the XML pieces into JS templates or something simple.

I can probably submit a PR to at least get us going with the source controlling.