Add yamllint configuration and fix lint warnings#66
Merged
jeffwidman merged 1 commit intomainfrom Mar 13, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds YAML linting to the repository and updates existing GitHub Actions workflow YAML to conform to the new lint rules.
Changes:
- Add a
.yamllint.yamlconfiguration (with repo-specific rule overrides and ignore paths). - Add a GitHub Actions workflow to run
yamllinton PRs and pushes tomain. - Apply formatting/lint-suppression fixes across existing workflows (notably
on:truthy suppression andsmoke.ymlspacing/indentation fixes).
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
.yamllint.yaml |
Introduces yamllint configuration and ignore patterns. |
.github/workflows/yamllint.yml |
New CI workflow that runs yamllint in GitHub Actions. |
.github/workflows/smoke.yml |
Fixes spacing/indentation and suppresses on: truthy lint. |
.github/workflows/scorecard.yml |
Suppresses on: truthy lint. |
.github/workflows/ghcr.yml |
Suppresses on: truthy lint. |
.github/workflows/codeql.yml |
Suppresses on: truthy lint. |
.github/workflows/ci.yml |
Suppresses on: truthy lint. |
jeffwidman
force-pushed
the
add-yamllint
branch
from
eb37ce9 to
14e2c73
Compare
Member
Author
|
Long term, it kills me that we spin up a full actions workflow here just for yamllint which is already installed on actions runners... If we add more linters down the road, it probably makes more sense to throw this in there with them, since this is really more of a sanity check than anything else. EDIT: Wow, only 4s for the yamllint run!! Actions has massively reduced their overhead of spinning up a job since I last checked. |
- Add .yamllint.yaml config (disable document-start, line-length rules; ignore vendor/) - Add yamllint CI workflow - Fix truthy warnings in all workflow files with inline disable comments - Fix bracket spacing in smoke.yml - Fix step indentation in smoke.yml - Fix comment indentation in smoke.yml
jeffwidman
force-pushed
the
add-yamllint
branch
from
14e2c73 to
5ab048c
Compare
JamieMagee
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds yamllint to the repo:
.yamllint.yaml— config that disablesdocument-startandline-lengthrules, ignoresvendor/.github/workflows/yamllint.yml— CI workflow to run yamllint on push to main and on PRsFixes all existing lint issues:
truthywarnings onon:keys in all workflow files via inline disable commentssmoke.ymlsmoke.yml(was 4-space, now consistent 6-space)smoke.yml