Fixed a bug with canceling an old sequence causing a new unrelated sequence to get canceled #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DoubleLoopAndy
commented
Aug 22, 2020
DoubleLoopAndy
commented
- Check that the sequence counter matches the requested counter before canceling the tweens in the sequence. To reproduce the original behavior, save the uniqueId of a finished sequence, start a new sequence (it should occupy the same slot), and then attempt to cancel the original uniqueId. The new sequence will get canceled before it has a chance to do anything.
…e canceling the tweens in the sequence. To reproduce the original behavior, save the uniqueId of a finished sequence, start a new sequence (it should occupy the same slot), and then attempt to cancel the original uniqueId. The new sequence will get canceled before it has a chance to do anything.
DoubleLoopAndy
commented
Aug 22, 2020
| int tweenId = seq.current.tween.uniqueId; | ||
| int tweenIndex = tweenId & 0xFFFF; | ||
| removeTween(tweenIndex); | ||
| if (seq.counter == backCounter) { |
Author
There was a problem hiding this comment.
Without this test, an unrelated sequence can be canceled.
|
This is actually happening, and in my case it's quite random |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.