feat(collections/unstable): accept Iterable in interleave#7088
Open
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Open
feat(collections/unstable): accept Iterable in interleave#7088tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Iterable in interleave#7088tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7088 +/- ##
=======================================
Coverage 94.41% 94.41%
=======================================
Files 630 630
Lines 50490 50518 +28
Branches 8949 8959 +10
=======================================
+ Hits 47669 47698 +29
Misses 2249 2249
+ Partials 572 571 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interleavenow widens the API toIterablewithout extra cost for array callers. This is in line with the general direction of the collections module.interleaveis very close tozipthat does not supportIterable, but looking at the module as a whole, I think it'szipthat needs to change.Also added a two-array fast path (no inner loop, no per-pair bounds check) and a branch for equal-length inputs where the length guard is unnecessary. This should help with two very common use cases. The general unequal-length path is unchanged.