Skip to content

Conversation

@timreichen
Copy link
Contributor

No description provided.

@timreichen timreichen requested a review from kt3k as a code owner January 13, 2026 19:45
@timreichen timreichen changed the title refactor(tools): remove @ts-nocheck in lint_plugin.ts and lint_plugin_test.ts refactor: remove @ts-nocheck in lint_plugin.ts and lint_plugin_test.ts Jan 13, 2026
@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.17%. Comparing base (c3e47e8) to head (0041294).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6954      +/-   ##
==========================================
+ Coverage   94.07%   94.17%   +0.10%     
==========================================
  Files         600      599       -1     
  Lines       43528    43187     -341     
  Branches     6986     6931      -55     
==========================================
- Hits        40950    40673     -277     
+ Misses       2524     2459      -65     
- Partials       54       55       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this

I split test task into test (main one) and test:tools and skipped the latter in v1 as these tests can't pass in Deno v1 (and probably we don't need to pass them in v1)

@kt3k kt3k changed the title refactor: remove @ts-nocheck in lint_plugin.ts and lint_plugin_test.ts chore: remove @ts-nocheck in lint_plugin.ts and lint_plugin_test.ts Jan 26, 2026
@kt3k kt3k merged commit d3d496a into denoland:main Jan 26, 2026
33 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants