Switch from using keyCode to which on event and prevented combobox from#15
Open
kycook wants to merge 1 commit intodellsala:masterfrom
Open
Switch from using keyCode to which on event and prevented combobox from#15kycook wants to merge 1 commit intodellsala:masterfrom
kycook wants to merge 1 commit intodellsala:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, I made a change so when ctrl or a combination of ctrl and another character is pressed in the input box, the drop-down does not open. I ran across this scenario because my web app allows users to press Ctrl+S to save. In that case, I didn't want the drop-down to show immediately after using a keyboard shortcut.
Second, I replaced references to keyCode with references to which as recommended by jQuery.