Fixed border around drop-down and changed style to prevent horizontal scrolling#10
Open
kycook wants to merge 1 commit intodellsala:masterfrom
Open
Fixed border around drop-down and changed style to prevent horizontal scrolling#10kycook wants to merge 1 commit intodellsala:masterfrom
kycook wants to merge 1 commit intodellsala:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the border from the ul element to the combobox_selector so that the border would be around the entire drop-down when there is a vertical scrollbar.
I also added a CSS property to force word breaks. This is to prevent horizontal scrolling in the drop-down with very long options that have no spaces.