Fix: response name assignment in request handler execution#309
Open
pksorensen wants to merge 4 commits intodelegateas:masterfrom
Open
Fix: response name assignment in request handler execution#309pksorensen wants to merge 4 commits intodelegateas:masterfrom
pksorensen wants to merge 4 commits intodelegateas:masterfrom
Conversation
Fixes deserialization errors when restoring snapshots that contain EntityCollection fields (e.g., Email.From, Email.To, PhoneCall.From, Appointment.OptionalAttendees). Issue: - Microsoft.Xrm.Sdk.EntityCollection contains a DataCollection<Entity> property that lacks a parameterless constructor, causing System.Text.Json deserialization to fail with: "Deserialization of types without a parameterless constructor... is not supported" - This affects any activity entity with activity party collections Solution: - Created EntityCollectionDTO for JSON deserialization using JsonElement - Added special handling in ConvertValueFromSerializableDTO() to: 1. Parse JSON manually using JsonElement (avoiding constructor requirement) 2. Reconstruct Entity objects property-by-property (LogicalName, Id, Attributes) 3. Create new EntityCollection with reconstructed entities 4. Restore collection metadata (MoreRecords, PagingCookie, etc.) This follows the existing pattern used for OptionSetValueCollection deserialization. Tested by successfully restoring a snapshot containing email entities with From/To fields via XrmEmulator service startup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.