Skip to content

Set NSPrivacyTracking to true if NSPrivacyTrackingDomains is non-empty#902

Merged
ekharkunov merged 1 commit intodevfrom
Issue-901-set-nsprivacytracking-to-true
Mar 25, 2026
Merged

Set NSPrivacyTracking to true if NSPrivacyTrackingDomains is non-empty#902
ekharkunov merged 1 commit intodevfrom
Issue-901-set-nsprivacytracking-to-true

Conversation

@britzl
Copy link
Contributor

@britzl britzl commented Mar 24, 2026

This change automatically sets NSPrivacyTracking to true if NSPrivacyTrackingDomains is non-empty. This will avoid Apple error ITMS-91064 when uploading for testing or distribution.

Fixes #901

@britzl britzl changed the title Set NSPrivacyTracking to true if domains are set Set NSPrivacyTracking to true if NSPrivacyTrackingDomains is non-empty Mar 24, 2026
@britzl britzl added this to 1.12.4 Mar 24, 2026
@github-project-automation github-project-automation bot moved this to Needs triage in 1.12.4 Mar 24, 2026
@britzl britzl requested a review from ekharkunov March 24, 2026 13:15
@github-actions
Copy link

Summary - Extender code coverage report

Summary
Generated on: 03/24/2026 - 13:15:55
Coverage date: 03/24/2026 - 13:15:19
Parser: JaCoCo
Assemblies: 13
Classes: 82
Files: 82
Line coverage: 33% (1810 of 5473)
Covered lines: 1810
Uncovered lines: 3663
Coverable lines: 5473
Total lines: 11228
Branch coverage: 35.9% (733 of 2037)
Covered branches: 733
Total branches: 2037
Method coverage: Feature is only available for sponsors
Tag: 164_23491268230

Coverage

com/defold/extender - 26%
Name Line Branch
com/defold/extender 26% 29.3%
com/defold/extender/AppManifestConfiguration 100%
com/defold/extender/AppManifestPlatformConfig 100%
com/defold/extender/AsyncBuilder 0% 0%
com/defold/extender/BuilderConstants 0%
com/defold/extender/Configuration 100%
com/defold/extender/Extender 11.2% 10.3%
com/defold/extender/ExtenderApplication 0%
com/defold/extender/ExtenderBuildState 63.1% 57.1%
com/defold/extender/ExtenderConst 0%
com/defold/extender/ExtenderController 18.8% 21.9%
com/defold/extender/ExtenderException 42.8%
com/defold/extender/ExtenderUtil 66.8% 57.3%
com/defold/extender/ExtenderYamlSafeConstructor 100%
com/defold/extender/ExtensionManifestValidator 69.5% 55%
com/defold/extender/ManifestConfiguration 100%
com/defold/extender/ManifestPlatformConfig 100%
com/defold/extender/PlatformConfig 100%
com/defold/extender/PlatformNotSupportedException 0%
com/defold/extender/TemplateExecutor 33.3% 50%
com/defold/extender/Timer 0%
com/defold/extender/TreePrinter 0% 0%
com/defold/extender/Version 0%
com/defold/extender/VersionNotSupportedException 0%
com/defold/extender/WebSecurityConfig 0% 0%
com/defold/extender/WhitelistConfig 100%
com/defold/extender/ZipUtils 64.9% 56.6%
com/defold/extender/builders - 0%
Name Line Branch
com/defold/extender/builders 0% 0%
com/defold/extender/builders/CSharpBuilder 0% 0%
com/defold/extender/cache - 32.4%
Name Line Branch
com/defold/extender/cache 32.4% 16.6%
com/defold/extender/cache/CacheEntry 64.7% 75%
com/defold/extender/cache/CacheKeyGenerator 81.8% 100%
com/defold/extender/cache/DataCache
com/defold/extender/cache/DataCacheException 0%
com/defold/extender/cache/DataCacheFactory 5% 0%
com/defold/extender/cache/DummyDataCache 80%
com/defold/extender/cache/GCPDataCache 0% 0%
com/defold/extender/cache/LocalDiskDataCache 64.7% 16.6%
com/defold/extender/cache/info - 100%
Name Line Branch
com/defold/extender/cache/info 100% ****
com/defold/extender/cache/info/CacheInfoFileParser 100%
com/defold/extender/cache/info/CacheInfoFileWriter 100%
com/defold/extender/cache/info/CacheInfoWrapper 100%
com/defold/extender/log - 0%
Name Line Branch
com/defold/extender/log 0% 0%
com/defold/extender/log/ExtenderLogEnhancer 0% 0%
com/defold/extender/log/ExtenderLogEnhancerConfiguration 0% 0%
com/defold/extender/log/Markers 0%
com/defold/extender/metrics - 7.4%
Name Line Branch
com/defold/extender/metrics 7.4% ****
com/defold/extender/metrics/MetricsWriter 7.4%
com/defold/extender/process - 10.4%
Name Line Branch
com/defold/extender/process 10.4% 7.1%
com/defold/extender/process/ProcessExecutor 12.3% 8.8%
com/defold/extender/process/ProcessUtils 0% 0%
com/defold/extender/remote - 4.9%
Name Line Branch
com/defold/extender/remote 4.9% 0%
com/defold/extender/remote/RemoteBuildException 0%
com/defold/extender/remote/RemoteEngineBuilder 0% 0%
com/defold/extender/remote/RemoteHostConfiguration 0%
com/defold/extender/remote/RemoteInstanceConfig 87.5%
com/defold/extender/services - 46%
Name Line Branch
com/defold/extender/services 46% 44.7%
com/defold/extender/services/DataCacheService 79.8% 61.9%
com/defold/extender/services/DefoldSdkService 78.2% 66.6%
com/defold/extender/services/DefoldSdkServiceConfiguration
com/defold/extender/services/GCPInstanceService 0% 0%
com/defold/extender/services/GradleService 0%
com/defold/extender/services/GradleServiceInterface
com/defold/extender/services/HealthReporterService 80% 55.2%
com/defold/extender/services/MockGradleService 0%
com/defold/extender/services/RealGradleService 0% 0%
com/defold/extender/services/UserUpdateService 0% 0%
com/defold/extender/services/cocoapods - 51.4%
Name Line Branch
com/defold/extender/services/cocoapods 51.4% 54.9%
com/defold/extender/services/cocoapods/CocoaPodsService 2.1% 1.8%
com/defold/extender/services/cocoapods/CocoaPodsServiceBuildState 16.6% 0%
com/defold/extender/services/cocoapods/CreateBuildSpecArgs 60.7%
com/defold/extender/services/cocoapods/IConfigParser
com/defold/extender/services/cocoapods/LanguageSet 66.6% 50%
com/defold/extender/services/cocoapods/MainPodfile 20%
com/defold/extender/services/cocoapods/PlatformAndLanguageSet 0% 0%
com/defold/extender/services/cocoapods/PlatformSet 0% 0%
com/defold/extender/services/cocoapods/PlistBuddyWrapper 0% 0%
com/defold/extender/services/cocoapods/PodBuildSpec 81.8% 65.9%
com/defold/extender/services/cocoapods/PodfileParser 92.8% 81.8%
com/defold/extender/services/cocoapods/PodfileParsingException 100%
com/defold/extender/services/cocoapods/PodSpec 60.4% 40%
com/defold/extender/services/cocoapods/PodSpecParser 89.5% 79.1%
com/defold/extender/services/cocoapods/PodUtils 63% 51.4%
com/defold/extender/services/cocoapods/ResolvedPods 52.7% 45.6%
com/defold/extender/services/cocoapods/XCConfigParser 94.6% 88.4%
com/defold/extender/services/data - 80.7%
Name Line Branch
com/defold/extender/services/data 80.7% 75%
com/defold/extender/services/data/DefoldSdk 87.5% 75%
com/defold/extender/services/data/GCPInstanceState 0%
com/defold/extender/tracing - 18.7%
Name Line Branch
com/defold/extender/tracing 18.7% 12.5%
com/defold/extender/tracing/ExtenderExecutor 0% 0%
com/defold/extender/tracing/ExtenderTracerInterceptor 85.7% 50%
com/defold/extender/tracing/TraceIdInResponseServletFilter 0% 0%
com/defold/extender/utils - 0%
Name Line Branch
com/defold/extender/utils 0% 0%
com/defold/extender/utils/FrameworkUtil 0% 0%
com/defold/extender/utils/PodBuildUtil 0% 0%

@ekharkunov ekharkunov merged commit 8447d60 into dev Mar 25, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Needs triage to Done in 1.12.4 Mar 25, 2026
@ekharkunov ekharkunov deleted the Issue-901-set-nsprivacytracking-to-true branch March 25, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

App store marks bundle as "Invalid Binary"

2 participants