Test fixes + moving dtypes out of the test #4439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@delock/ @Yejing-Lai - this PR just applies your fixes but also tries to reduce the overall test time. Before, the 4 tests ran and took about 2 minutes to run. After #4263 + #4430 it runs the same tests but because of test setup takes much longer, now about an hour but only still runs those 4 tests. We were looking at that, but had a general question on if more tests were supposed to be added or enabled with that PR, or if we could revert to the way we had been skipping the tests before? cc: @mrwyattii |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.