refactor!: Update Agent tracing to only create one tracing span per loop #11203
Draft
sjrl wants to merge 6 commits intorefactor-agent-tool-invokerfrom
Draft
refactor!: Update Agent tracing to only create one tracing span per loop #11203sjrl wants to merge 6 commits intorefactor-agent-tool-invokerfrom
sjrl wants to merge 6 commits intorefactor-agent-tool-invokerfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
topic:tests
type:documentation
sjrl
force-pushed
the
single-tracing-span-per-loop
branch
from
9f04f16 to
e0b2632
Compare
Contributor
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
sjrl
force-pushed
the
single-tracing-span-per-loop
branch
from
155b0d1 to
bde728d
Compare
…e need to use Pipeline._run_component
sjrl
force-pushed
the
single-tracing-span-per-loop
branch
from
72e7fe1 to
f3619ff
Compare
…aystack into single-tracing-span-per-loop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Be more concise with the spans we create for Agent runs. Drop the now unnecessary use of
Pipeline._run_component(since break points have been removed) and instead create a single span per loop. This is in-line with the desired removal ofToolInvokeras a component.This allows the logic to be further simplified and understandable and creates more concise and readable traces.
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.