ci: fix stable version matching for Docker#10459
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
In #10387, we attempted to tag Docker images for Haystack releases as
stable.Unfortunately, when releasing 2.23, this did not work:
The issue is caused by an incorrect version match:
[[ "v2.23.0" =~ ^2\.[0-9]+\.[0-9]+$ ]].Proposed Changes:
How did you test it?
Docker release worklow was triggered in this PR with temporary workarounds: https://github.com/deepset-ai/haystack/actions/runs/21434580424/job/61722024574
The resolved bake definition includes the expected
stabletag:Notes for the reviewer
We will only be able to publish the
stabletag with the next release (2.24.0).This seems like the cleanest solution.
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.