Skip to content

ci: fix stable version matching for Docker#10459

Merged
anakin87 merged 4 commits intomainfrom
fix-docker-build-stable
Jan 28, 2026
Merged

ci: fix stable version matching for Docker#10459
anakin87 merged 4 commits intomainfrom
fix-docker-build-stable

Conversation

@anakin87
Copy link
Copy Markdown
Member

@anakin87 anakin87 commented Jan 28, 2026

Related Issues

In #10387, we attempted to tag Docker images for Haystack releases as stable.

Unfortunately, when releasing 2.23, this did not work:

The issue is caused by an incorrect version match: [[ "v2.23.0" =~ ^2\.[0-9]+\.[0-9]+$ ]].

Proposed Changes:

  • fix the pattern for matching a stable version (add "v" prefix)
  • add debug output to workflow

How did you test it?

Docker release worklow was triggered in this PR with temporary workarounds: https://github.com/deepset-ai/haystack/actions/runs/21434580424/job/61722024574

The resolved bake definition includes the expected stable tag:

{
    "group": {
      "default": {
        "targets": [
          "base"
        ]
      }
    },
    "target": {
      "base": {
        "context": ".",
        "dockerfile": "Dockerfile.base",
        "args": {
          "base_image": "python:3.12-slim",
          "build_image": "python:3.12-slim",
          "haystack_version": "main"
        },
        "tags": [
          "deepset/haystack:base-pr-10459",
          "deepset/haystack:stable"  ### NOTE THE TAG. 
          # THIS TAG WAS MISSING IN https://github.com/deepset-ai/haystack/actions/runs/21391303215/job/61578641842
        ],
        "platforms": [
          "linux/amd64"
        ],
        "output": [
          {
            "type": "docker"
          }
        ]
      }
    }
  }

Notes for the reviewer

We will only be able to publish the stable tag with the next release (2.24.0).
This seems like the cleanest solution.

Checklist

  • I have read the contributors guidelines and the code of conduct.
  • I have updated the related issue with new insights and changes.
  • I have added unit tests and updated the docstrings.
  • I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
  • I have documented my code.
  • I have added a release note file, following the contributors guidelines.
  • I have run pre-commit hooks and fixed any issue.

@vercel
Copy link
Copy Markdown

vercel Bot commented Jan 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
haystack-docs Ignored Ignored Preview Jan 28, 2026 10:33am

Request Review

@anakin87 anakin87 changed the title test stable matching in Docker ci: fix stable version matching for Docker Jan 28, 2026
@anakin87 anakin87 marked this pull request as ready for review January 28, 2026 10:48
@anakin87 anakin87 requested a review from a team as a code owner January 28, 2026 10:48
@anakin87 anakin87 requested review from julian-risch and removed request for a team January 28, 2026 10:48
@anakin87 anakin87 self-assigned this Jan 28, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@anakin87 anakin87 merged commit 2ebb32a into main Jan 28, 2026
14 checks passed
@anakin87 anakin87 deleted the fix-docker-build-stable branch January 28, 2026 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants