chore: HuggingFaceLocalChatGenerator - check defensively before shutting down executor

[anakin87]

Related Issues

#10341 (comment)

  Traceback (most recent call last):
    File "/Users/stefano.fiorucci/dev/haystack/haystack/components/generators/chat/hugging_face_local.py", line 259, in __del__
      if self._owns_executor:
  AttributeError: 'HuggingFaceLocalChatGenerator' object has no attribute '_owns_executor'

Not a test failure but I thought about improving a little bit this component, which sometimes also makes Windows tests hang in relation to executor deletion. So this change could help...

Proposed Changes:

• invoke self.executor.shutdown only after checking its existence: at deletion time, it might happen that the class still exists but its attributes have already been deleted. Aligned with InMemoryDocumentStore:
  

  haystack/haystack/document_stores/in_memory/document_store.py

  Line 129 in d7fe524

  if hasattr(self, "_owns_executor") and self._owns_executor and hasattr(self, "executor"):

How did you test it?

CI

Checklist

• I have read the contributors guidelines and the code of conduct.
• I have updated the related issue with new insights and changes.
• I have added unit tests and updated the docstrings.
• I've used one of the conventional commit types for my PR title: fix:, feat:, build:, chore:, ci:, docs:, style:, refactor:, perf:, test: and added ! in case the PR includes breaking changes.
• I have documented my code.
• I have added a release note file, following the contributors guidelines.
• I have run pre-commit hooks and fixed any issue.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
haystack-docs	Ignored		Jan 22, 2026 3:45pm

[julian-risch]

LGTM! 👍