chore: Update ConfirmationStrategy protocol
#430
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrl
requested review from
anakin87,
davidsbatista and
mpangrazzi
and removed request for
a team and
davidsbatista
Pull Request Test Coverage Report for Build 21067791473Details
💛 - Coveralls |
anakin87
reviewed
Jan 16, 2026
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
OK for me.
I probably pushed in this direction without fully knowing how it works...
Also interested in hearing @mpangrazzi's opinion...
mpangrazzi
approved these changes
Jan 19, 2026
Contributor
mpangrazzi
left a comment
mpangrazzi
left a comment
There was a problem hiding this comment.
@sjrl makes sense to me. Looks good!
Contributor
Author
|
Thanks for the review! I added these changes directly to deepset-ai/haystack#10403 so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
@anakin87 and @mpangrazzi I'm reverting to @mpangrazzi's original proposal for updating the ConfirmationStrategy protocol. After re-looking at the code I realize the
confirmation_strategy_contextis indeed a hard-required runtime param that needs to be supported even if not used.I thought the simplest thing to do right now is to make it explicit in the protocol especially since we don't have an easy way for users to pass arbitrary additional kwargs to the underlying run of the confirmation strategy.
How did you test it?
test_agent.pyfile to help catch some errors in the protocol and implemenationsNotes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.