Skip to content

chore: deepeval - fix types#3346

Merged
anakin87 merged 2 commits into
mainfrom
deepeval-fix-types
May 26, 2026
Merged

chore: deepeval - fix types#3346
anakin87 merged 2 commits into
mainfrom
deepeval-fix-types

Conversation

@anakin87
Copy link
Copy Markdown
Member

Related Issues

Proposed Changes:

  • ignore the specific type error; my impression is that Deepeval type is not well specified
  • specialize existing type ignore

How did you test it?

CI

Checklist

@github-actions
Copy link
Copy Markdown
Contributor

Coverage report (deepeval)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/deepeval/src/haystack_integrations/components/evaluators/deepeval
  metrics.py
Project Total  

This report was generated by python-coverage-comment-action

@anakin87 anakin87 marked this pull request as ready for review May 25, 2026 07:57
@anakin87 anakin87 requested a review from a team as a code owner May 25, 2026 07:57
@anakin87 anakin87 requested review from sjrl and removed request for a team May 25, 2026 07:57
@anakin87 anakin87 self-assigned this May 25, 2026
Copy link
Copy Markdown
Contributor

@sjrl sjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anakin87 anakin87 merged commit e6865ce into main May 26, 2026
16 checks passed
@anakin87 anakin87 deleted the deepeval-fix-types branch May 26, 2026 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants