Conversation
… at runtime to add_memories. Made attribute of MemoryWriter with default set to True
Contributor
Coverage report (mem0)Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
bogdankostic
requested changes
May 20, 2026
Contributor
bogdankostic
left a comment
There was a problem hiding this comment.
Looking already good overall, just have some minor comments here and there.
…ers/mem0/retriever.py Co-authored-by: bogdankostic <bogdankostic@web.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
Add a Mem0 integration for Haystack.
This PR adds:
Mem0MemoryStorewhich is meant to house all relevant methods for interacting with the Mem0 Memory client.Mem0MemoryStore:Mem0MemoryRetrieverandMem0MemoryWriter. Very analogous to our Retriever and Writer components for Document Stores.Mem0MemoryRetrieverToolandMem0MemoryWriterToolthat have configuration options.I recommend checking out the two example files:
agent_memory.pyto see how the tools can be used in practiceagent_memory_components.pyto see how the components can be used in practiceHow did you test it?
Added unit and integration tests.
Notes for the reviewer
This was initially based off of the Mem0 integration added in haystack-experimental.
Some notable differences are:
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.